Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] deleted files which may not be needed anymore #225

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

davidcalderon03
Copy link
Member

@davidcalderon03 davidcalderon03 commented Sep 8, 2024

Description

This PR does the following:

  • Deletes urc_gazebo
  • Deletes everything in urc_platform except for the joystick driver
  • Deletes unnecessary documents in the documents folder
  • Removes urc_imu, urc_manipulation, and urc_scripts

Testing Steps

  1. colcon build
  2. . install/setup.bash
  3. ros2 launch urc_bringup bringup.launch.py
  4. ros2 launch urc_bringup bringup_simulation.launch.py

Expectation: The thing which does the thing does the thing

Self Checklist

  • I have formatted my code using ament_uncrustify --reformat
  • I have tested that the new behavior works

@davidcalderon03 davidcalderon03 added the type/refactor Refactors a section of the codebase label Sep 8, 2024
@davidcalderon03 davidcalderon03 self-assigned this Sep 8, 2024
@davidcalderon03 davidcalderon03 changed the title Deleted files which I believe we do not need anymore Deleted files which may not be needed anymore Sep 8, 2024
@davidcalderon03
Copy link
Member Author

NOTE. The main concern as of now is that we need to move the STL files over to urc_hw_description, since they are pulled from urc_gazebo. Everything else in urc_gazebo (cpp files, launch scripts, other assets) should be deleted

@davidcalderon03 davidcalderon03 removed the request for review from yambati03 September 8, 2024 17:10
@davidcalderon03
Copy link
Member Author

Everything seems to work fine still, the only concern as of now is that we have two versions of the joystick driver, one is the old one in urc_platform and the new one Simon made in urc_scripts (which is a Python-translated version). I think we can keep both for now, but we need to discuss which one we would want to use moving forward (probably will be deleting urc_platform overall).

@davidcalderon03 davidcalderon03 marked this pull request as ready for review October 4, 2024 21:52
@davidcalderon03 davidcalderon03 changed the title Deleted files which may not be needed anymore [cleanup] deleted files which may not be needed anymore Oct 6, 2024
@mrinalTheCoder mrinalTheCoder merged commit b726cce into master Oct 25, 2024
3 of 4 checks passed
@mrinalTheCoder mrinalTheCoder deleted the cleanup/unused branch October 25, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/refactor Refactors a section of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants