Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #144 #145

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Fix #144 #145

merged 1 commit into from
Mar 3, 2023

Conversation

Andor233
Copy link
Contributor

No description provided.

@hbcarlos
Copy link
Member

hbcarlos commented Jan 3, 2023

Thanks @Andor233!

IsabelParedes
IsabelParedes approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@IsabelParedes IsabelParedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Andor233
Copy link
Contributor Author

Andor233 commented Jan 4, 2023

Sorry I am not familiar with your build system, what's going wrong with it?

@Andor233
Copy link
Contributor Author

Andor233 commented Jan 4, 2023

And I find that it already not pass in your past commit

@hbcarlos
Copy link
Member

hbcarlos commented Mar 3, 2023

Hi @Andor233! Sorry for the delay!

I took the liberty to rebase your PR to pick the CI fix from main. Thank you so much for your contribution!

@hbcarlos hbcarlos merged commit 6366c5b into RoboStack:main Mar 3, 2023
@IsabelParedes IsabelParedes mentioned this pull request May 31, 2023
Closed
@IsabelParedes IsabelParedes mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsabelParedes IsabelParedes IsabelParedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andor233 @hbcarlos @IsabelParedes