[solvers] Fix Gurobi console logging config to happen first #22134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: high
release notes: none
|
+@cohnt could you check this again, please? Thanks! |
cohnt
reviewed
Nov 6, 2024
There was a problem hiding this comment.
I confirmed that this removes the previously-present console spam. Thanks!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers
solvers/gurobi_solver.cc line 991 at r1 (raw file):
// Copy the remaining options into model_env. Set the logging level first, so // that changes to any of the other options are uniformed logged (or not).
nit: grammar
Suggestion:
any of the other options are uniformly logged (or not)
jwnimmer-tri
force-pushed
the
gurobi-spam
branch
from
eebf202
to
bdb7b24
Compare
|
+@sherm1 for platform review per schedule, please. |
sherm1
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Platform
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees cohnt,sherm1(platform)
cohnt
added a commit
to cohnt/drake
that referenced
this pull request
Nov 7, 2024
Merge remote-tracking branch 'upstream/master' into gcs-preprocessing-parallel [tools] Suppress more Valgrind false positives in MOSEK (RobotLocomotion#22140) Update parsing infrastructure (RobotLocomotion#22102) 1. MultibodyPlant::RegisterVisualGeometry() can now take a GeometryInstance. - Clean up documentation. - Extend tests to include what is *actually* done. 2. SDF parser makes use of new API. - Stop returning optional<unique_ptr<>> (simply return the unique ptr). - Instead of constructing, deconstructing, and reconstructing geometry instances, we just pass the instance. [schema] Add Rotation::Sample (RobotLocomotion#22113) This bring it on par with Transform::Sample. Move the warning on small-size PSD matrix to each solver backend. (RobotLocomotion#22136) [solvers] Fix Gurobi console logging config to happen first (RobotLocomotion#22134) [bindings] Re-enable some gym test cases on macOS (RobotLocomotion#22112) [drake_gym] Add info_handler callback (RobotLocomotion#21900) Set gradient sparsity pattern in LorentzConeConstraint and RotatedLorentzConeConstraint. (RobotLocomotion#22125) Merge master. Drop a TODO. Fix bug when inadvertantly trying to preprocess edges into the start and goal vertex. Hold a limited number of programs in memory at one time. Move the construction of the preprocessing program to a separate function for better portability. Merge up-to-date version of SolveInParallel. Merge in preprocessing solver options behavior from branch. wip lint Use the preprocessing solver options even if a specific preprocessing solver is not specified. Fix another segfault. Bring back the parallelization, revealing the segfault. Update this test to reflect the new error message. First pass at parallelizing PreprocessShortestPath. Fix a segfault when initial_guesses is unset. Temporarily disable the parallelism for debugging. finalize interface wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22107, again.
The bug was introduced subsequent to the most recent release, so we don't need a release note announcing the fix.
This change is