Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Improvements on the transcript request and switch department process #419

Merged
merged 2 commits into from
Jun 29, 2020

Conversation

renatobecker
Copy link
Contributor

@renatobecker renatobecker commented May 28, 2020

Related to RocketChat/Rocket.Chat#17774
Closes #428

This PR adds two improvements on the:

  • Transcript request feature
  • Switch department process

Transcript request
Currently, when a conversation is closed the Widget allows end-users to request the chat transcript, but we improve this process on the agents-side, so now they will be able to request the chat transcript during the conversation, which means that, in this case, the widget doesn't need to request it again.

Switch department
In the latest release we made some changes(this PR) to the form validations and those changes also impacted the Switch Department form, which is not working as well as expected. This PR also fixes the problem.

@renatobecker renatobecker added the enhancement New feature or request label May 28, 2020
@renatobecker renatobecker requested review from tassoevan and ggazzo May 28, 2020 17:30
src/lib/room.js Outdated
export const getGreetingMessages = (messages) => {
return messages && messages.filter((msg) => msg.trigger);
}
export const getGreetingMessages = (messages) => messages && messages.filter((msg) => msg.trigger);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should go before 154, as it is a const declaration (so not hoisted) of a function used in loadMessages

@vanntile
Copy link

/src/routes/SwitchDepartment/container.js is missing a

await dispatch({ department });

on line 31, as it does not update the department in the local storage when it should, effectively messing up the change of departments.

@renatobecker
Copy link
Contributor Author

@vanntile thanks for your review, but none of the points you mentioned are related to this Pull Request, they're improvements/fixes on the existing codebase, so feel free to submit a PR with the changes you deem necessary.

Thanks.

@vanntile
Copy link

@renatobecker while this might be true to the above snippet, the comment on the actual file is relevant, as your line change will have no effect whatsoever as a const declaration at the line you wrote it. Just wanted to make sure you understand it damages the effect of the change. You're the contributor, you decide.

@renatobecker
Copy link
Contributor Author

@renatobecker while this might be true to the above snippet, the comment on the actual file is relevant, as your line change will have no effect whatsoever as a const declaration at the line you wrote it. Just wanted to make sure you understand it damages the effect of the change. You're the contributor, you decide.

The only thing that has been changed is that now the function is an arrow function, the position in the file is the same as before. If you want to move the line number where the function is declared, feel free to do that, I'll be happy to review and merge your implementation.

@ggazzo ggazzo merged commit 6fa0872 into develop Jun 29, 2020
@ggazzo ggazzo deleted the improve-transcript-request-process branch June 29, 2020 19:33
@ggazzo ggazzo mentioned this pull request Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omnichannel visitors no longer able to switch departments in v3.3.0
3 participants