[FIX] Closing sidebar when room menu is clicked. (#13842)

* Don't close sidebar when room menu is clicked. * Add tests to check if sidebar closes after clicking sidebar item menu * Update side-nav.page.js * Fix typo in class name * Update side-nav.page.js * Update 08-resolutions.js
RocketChat · Apr 6, 2019 · 0383c28 · 0383c28
1 parent 3adef03
commit 0383c28
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/app/ui-sidenav/client/sidebarItem.js b/app/ui-sidenav/client/sidebarItem.js
@@ -101,6 +101,7 @@ Template.sidebarItem.events({
 		return menu.close();
 	},
 	'click .sidebar-item__menu'(e) {
+		e.stopPropagation(); // to not close the menu
 		e.preventDefault();
 
 		const canLeave = () => {

diff --git a/tests/end-to-end/ui/08-resolutions.js b/tests/end-to-end/ui/08-resolutions.js
@@ -35,6 +35,15 @@ describe('[Resolution]', () => {
 				mainContent.mainContent.getLocation().should.not.deep.equal({ x:0 });
 			});
 
+			it('it should not close sidebar on pressing the sidebar item menu', () => {
+				sideNav.firstSidebarItem.moveToObject();
+				sideNav.firstSidebarItemMenu.waitForVisible(10000);
+				sideNav.firstSidebarItemMenu.click();
+				browser.pause(100);
+				mainContent.mainContent.getLocation().should.not.deep.equal({ x:0 });
+				sideNav.popoverOverlay.click();
+			});
+
 			it('it should open general channel', () => {
 				sideNav.openChannel('general');
 			});

diff --git a/tests/pageobjects/side-nav.page.js b/tests/pageobjects/side-nav.page.js
@@ -52,6 +52,10 @@ class SideNav extends Page {
 
 	get sidebarWrap() { return browser.element('.sidebar-wrap'); }
 
+	get firstSidebarItem() { return browser.element('.sidebar-item'); }
+	get firstSidebarItemMenu() { return browser.element('.sidebar-item__menu'); }
+	get popoverOverlay() { return browser.element('.rc-popover.rc-popover--sidebar-item'); }
+
 	// Opens a channel via rooms list
 	openChannel(channelName) {
 		browser.waitForVisible(`.sidebar-item__ellipsis=${ channelName }`, 10000);