[FIX] Closing sidebar when room menu is clicked. #13842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelgabriel
changed the title
tassoevan
previously approved these changes
Mar 25, 2019
sampaiodiego
requested changes
Mar 26, 2019
There was a problem hiding this comment.
can you please add an end-to-end test to prevent this? like, test clicking on the '3 dots' and see if the sidebar is still open.
I would add it after opening the menu on this test.
Kailash0311
force-pushed
the
sidebar-close
branch
from
5dfa3b0 to
d5577a0
Compare
|
@sampaiodiego I have added the test, can you please review it |
tests/pageobjects/side-nav.page.js
Outdated
| @@ -52,6 +52,8 @@ class SideNav extends Page { | |||
|
|
|||
| get sidebarWrap() { return browser.element('.sidebar-wrap'); } | |||
|
|
|||
| get sidebarItemMenu() { return browser.element('.sidebar-menu'); } | |||
There was a problem hiding this comment.
I haven't found this element on the source code. Maybe you were trying to get sidebar-item__menu instead?
|
@sampaiodiego I've rectified the mistake. |
sampaiodiego
previously requested changes
Apr 2, 2019
There was a problem hiding this comment.
thanks @Kailash0311 .. but the tests are not passing.
you can run tests locally by running meteor setting the env var TEST_MODE=true like:
TEST_MODE=true meteor
and in another console run meteor npm run chimp-test
rodrigok
approved these changes
Apr 6, 2019
wreiske
added a commit
to wreiske/Rocket.Chat
that referenced
this pull request
Apr 7, 2019
… into emoji-upgrades * 'emoji-upgrades' of https://github.com/wreiske/Rocket.Chat: Settings: disable reset button (RocketChat#14026) Settings: hiding reset button for readonly fields (RocketChat#14025) [NEW] Add support to updatedSince parameter in emoji-custom.list and deprecated old endpoint (RocketChat#13510) [IMPROVE] Add permission to change other user profile avatar (RocketChat#13884) [IMPROVE] UI of Permissions page (RocketChat#13732) [NEW] Chatpal: Enable custom search parameters (RocketChat#13828) (RocketChat#13829) [FIX] Closing sidebar when room menu is clicked. (RocketChat#13842) [FIX] Check settings for name requirement before validating (RocketChat#14021) Fix debug logging not being enabled by the setting (RocketChat#13979) [FIX] Links and upload paths when running in a subdir (RocketChat#13982)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13841.
Stops propagation of "closing the menu event" onto the sidebar_menu class.