fix: multiple indexes creations during migrations (#31413)

.changeset/fresh-maps-rhyme.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+fix: multiple indexes creation error during 304 migration

apps/meteor/server/models/raw/BaseRaw.ts

@@ -78,14 +78,26 @@ export abstract class BaseRaw<
 		this.preventSetUpdatedAt = options?.preventSetUpdatedAt ?? false;
 	}
 
+	private pendingIndexes: Promise<void> | undefined;
+
 	public async createIndexes() {
 		const indexes = this.modelIndexes();
 		if (this.options?._updatedAtIndexOptions) {
 			indexes?.push({ ...this.options._updatedAtIndexOptions, key: { _updatedAt: 1 } });
 		}
 
 		if (indexes?.length) {
-			return this.col.createIndexes(indexes);
+			if (this.pendingIndexes) {
+				await this.pendingIndexes;
+			}
+
+			this.pendingIndexes = this.col.createIndexes(indexes) as unknown as Promise<void>;
+
+			void this.pendingIndexes.finally(() => {
+				this.pendingIndexes = undefined;
+			});
+
+			return this.pendingIndexes;
 		}
 	}
 

apps/meteor/server/startup/migrations/v304.ts

@@ -6,6 +6,16 @@ addMigration({
 	version: 304,
 	name: 'Drop wrong index from analytics collection',
 	async up() {
+		const indexes = await Analytics.col.indexes();
+
+		if (
+			indexes.find(
+				(index) => index.name === 'room._id_1_date_1' && index.partialFilterExpression && index.partialFilterExpression.type === 'rooms',
+			)
+		) {
+			return;
+		}
+
 		await Analytics.col.dropIndex('room._id_1_date_1');
 		await Analytics.createIndexes();
 	},