Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple indexes creations during migrations #31413

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jan 10, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: 9427f0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8c69edd) 59.75% compared to head (9427f0c) 49.54%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31413       +/-   ##
============================================
- Coverage    59.75%   49.54%   -10.22%     
============================================
  Files         1791     3312     +1521     
  Lines        34886    81416    +46530     
  Branches      7272    16702     +9430     
============================================
+ Hits         20847    40334    +19487     
- Misses       12428    36373    +23945     
- Partials      1611     4709     +3098     
Flag Coverage Δ
e2e 53.06% <ø> (+0.03%) ⬆️
e2e-api 40.68% <66.66%> (?)
unit 76.64% <14.28%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review January 10, 2024 16:28
@ggazzo ggazzo requested a review from a team as a code owner January 10, 2024 16:28
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 10, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 10, 2024
@kodiakhq kodiakhq bot merged commit c5693fb into develop Jan 10, 2024
43 of 44 checks passed
@kodiakhq kodiakhq bot deleted the fix/indexes-creation-2 branch January 10, 2024 18:22
gabriellsh added a commit that referenced this pull request Jan 10, 2024
…ve/Notifications

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(i18n): Translation's lint and load (#31343)
  fix: multiple indexes creations during migrations (#31413)
  feat: add `ImageGallery` zoom controls (#31369)
  chore: internalize flow-router (from meteor 3 branch) (#31365)
  chore: internalize meteor run as user (from meteor 3) (#31370)
  chore: internalize meteor inject initial (from meteor 3) (#31367)
  chore: internalize meteor cookies (from meteor 3) (#31366)
@casalsgh casalsgh added this to the 6.6 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants