Regression: addPermissionToRole argument (#15267)

RocketChat · Aug 27, 2019 · 2ef6b5b · 2ef6b5b
1 parent a455a61
commit 2ef6b5b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/authorization/client/views/permissions.js b/app/authorization/client/views/permissions.js
@@ -191,7 +191,7 @@ Template.permissionsTable.events({
 
 		const action = ~permission.roles.indexOf(role) ? 'authorization:removeRoleFromPermission' : 'authorization:addPermissionToRole';
 
-		return Meteor.call(action, permission, role);
+		return Meteor.call(action, permissionId, role);
 	},
 });
 

diff --git a/app/models/server/models/Permissions.js b/app/models/server/models/Permissions.js
@@ -11,7 +11,7 @@ export class Permissions extends Base {
 	}
 
 	findOneById(_id) {
-		return this.findOne(_id);
+		return this.findOne({ _id });
 	}
 
 	createOrUpdate(name, roles) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -191,7 +191,7 @@ Template.permissionsTable.events({ @@
     		const action = ~permission.roles.indexOf(role) ? 'authorization:removeRoleFromPermission' : 'authorization:addPermissionToRole';
-    		return Meteor.call(action, permission, role);
+    		return Meteor.call(action, permissionId, role);
     	},
     });
@@ Expand Down @@