Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: addPermissionToRole argument as string #15267

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Regression: addPermissionToRole argument as string #15267

merged 1 commit into from
Aug 27, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 27, 2019

No description provided.

@ggazzo ggazzo added this to the 2.0.0 milestone Aug 27, 2019
@ggazzo ggazzo requested review from mrsimpson and tassoevan August 27, 2019 16:12
@ggazzo ggazzo added the ui/ux label Aug 27, 2019
tassoevan
tassoevan approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that could have been avoided with type checking... 🤔

@ggazzo ggazzo merged commit 2ef6b5b into develop Aug 27, 2019
@ggazzo ggazzo deleted the regression/settings branch August 27, 2019 16:43
rodrigok pushed a commit that referenced this pull request Aug 28, 2019
@ggazzo @rodrigok
Regression: addPermissionToRole argument (#15267)
eb32fce
@sampaiodiego sampaiodiego mentioned this pull request Sep 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

@mrsimpson mrsimpson Awaiting requested review from mrsimpson

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @tassoevan