Regression: Incorrect system message upon adding/editing SLA policy f…

…or a room. (#28151)
RocketChat · Feb 28, 2023 · 70466e9 · 70466e9
1 parent adbc8e5
commit 70466e9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/apps/meteor/ee/app/livechat-enterprise/server/api/lib/sla.ts b/apps/meteor/ee/app/livechat-enterprise/server/api/lib/sla.ts
@@ -48,7 +48,7 @@ export async function findSLA({
 export const updateRoomSLA = async (
 	roomId: string,
 	user: Required<Pick<IUser, '_id' | 'username' | 'name'>>,
-	sla: IOmnichannelServiceLevelAgreements,
+	sla: Pick<IOmnichannelServiceLevelAgreements, '_id' | 'name' | 'dueTimeInMinutes'>,
 ) => {
 	await Promise.all([updateInquiryQueueSla(roomId, sla), updateRoomSlaWeights(roomId, sla), addSlaChangeHistoryToRoom(roomId, user, sla)]);
 };

diff --git a/apps/meteor/ee/app/livechat-enterprise/server/hooks/onSaveVisitorInfo.ts b/apps/meteor/ee/app/livechat-enterprise/server/hooks/onSaveVisitorInfo.ts
@@ -1,4 +1,4 @@
-import type { IOmnichannelRoom, IUser } from '@rocket.chat/core-typings';
+import type { IOmnichannelRoom, IOmnichannelServiceLevelAgreements, IUser } from '@rocket.chat/core-typings';
 import { OmnichannelServiceLevelAgreements } from '@rocket.chat/models';
 
 import { callbacks } from '../../../../../lib/callbacks';
@@ -11,7 +11,10 @@ const updateSLA = async (room: IOmnichannelRoom, user: Required<Pick<IUser, '_id
 		return removeRoomSLA(room._id, user);
 	}
 
-	const sla = await OmnichannelServiceLevelAgreements.findOneById(slaId, { projection: { _id: 1, dueTimeInMinutes: 1 } });
+	const sla: Pick<IOmnichannelServiceLevelAgreements, '_id' | 'name' | 'dueTimeInMinutes'> | null =
+		await OmnichannelServiceLevelAgreements.findOneById(slaId, {
+			projection: { _id: 1, name: 1, dueTimeInMinutes: 1 },
+		});
 	if (!sla) {
 		throw new Error(`SLA not found with id: ${slaId}`);
 	}