Regression: Incorrect system message upon adding/editing SLA policy for a room. #28151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28151 +/- ##
===========================================
- Coverage 44.86% 43.83% -1.03%
===========================================
Files 765 741 -24
Lines 14893 14532 -361
Branches 2069 2067 -2
===========================================
- Hits 6681 6370 -311
+ Misses 7922 7868 -54
- Partials 290 294 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
cauefcr
previously approved these changes
Feb 27, 2023
KevLehman
reviewed
Feb 27, 2023
apps/meteor/ee/app/livechat-enterprise/server/hooks/onSaveVisitorInfo.ts
Outdated
Show resolved
Hide resolved
KevLehman
approved these changes
Feb 27, 2023
cauefcr
approved these changes
Feb 27, 2023
dionisio-bot
bot
added
stat: ready to merge
sampaiodiego
added
type: regression
and removed
stat: ready to merge
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Feb 28, 2023
…search-nonlatin-rooms * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix mentioning rooms with special chars (#28206) Regression: Incorrect system message upon adding/editing SLA policy for a room. (#28151) Chore: anonymous e2e test dispatch error (#28171) Regression: Remove unnecessary messages from Email transcript (#28165) Regression: Update color tokens for voip footer (#28197) Regression: Image Attachment Description size (#28149) Regression: Fix omnichannel chat forwarding not working (#28117) Regression: Support generating pdfs from queue (#28162) Regression: Regular users were not able to leave federated rooms (#28148) Regression: Fix slash commands (#28168) Regression: Incorrect installation flow on app detail and upload app pages (#28173) replace deprecated color tokens (#28164) Regression: Fix toggle theme breaking UI (#28161) Chore: Remove meteor build --debug option (#28170) fix: hide register workspace option for non-admin users (#28154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/OC-692
Steps to test or reproduce
Further comments