Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine autocomplete username suggestions #10872

Closed
timkinnane opened this issue May 25, 2018 · 0 comments
Closed

Refine autocomplete username suggestions #10872

timkinnane opened this issue May 25, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@timkinnane
Copy link
Contributor

On open.rocket.chat or any server with many users, the autocomplete username suggestions after @ are often not very useful, I think for two reasons:

  1. The search includes matching on email address - I don't see any reason for this and it just pollutes the list with irrelevant usernames.
  2. The search isn't sorted to promote users in the room, so the person you're most likely trying to address often won't be in the list at all.

On the first point, I know it's possible to configure this, but the default configuration should provide the best experience, so I would suggest removing email from default search fields. I don't see why it's even an option, when you're trying to "at" someone, you can't use their email and wouldn't usually know it anyway. Isn't it also a privacy issue, because you could detect someones email address from the suggestions?

This was created from discussion on #10132, but there's many other relevant issues describing a poor experience with search completion. e.g. #10791, #1446, #10004, #874, #2980.

@engelgabriel engelgabriel added this to the 0.67.0 milestone Jun 8, 2018
@ggazzo ggazzo added the ui/ux label Jun 10, 2018
@tassoevan tassoevan self-assigned this Jul 10, 2018
ggazzo pushed a commit that referenced this issue Jul 19, 2018
Closes #10872

- [x] Removes email addresses from default user search (**impacts on search bar too**)
- [x] Suggests first users that sent text messages in the room
- [x] All users are listed together with real name and status
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants