[FIX] Refinements in message popup mentions #11441

tassoevan · 2018-07-12T19:48:46Z

Closes #10872

Removes email addresses from default user search (impacts on search bar too)
Suggests first users that sent text messages in the room
All users are listed together with real name and status

tassoevan and others added 4 commits July 10, 2018 23:32

Remove email addresses as search fields for accounts

53dd793

Refactor code

4b095ae

Fetch mentions suggestions only from regular messages in a room

111795b

Add more fields in suggested mentions

3ca8d54

tassoevan added type: bug ui/ux labels Jul 12, 2018

tassoevan added this to the 0.67.0 milestone Jul 12, 2018

tassoevan self-assigned this Jul 12, 2018

tassoevan requested a review from ggazzo July 12, 2018 19:48

engelgabriel temporarily deployed to rocket-chat-pr-11441 July 12, 2018 19:49 Inactive

ggazzo previously approved these changes Jul 18, 2018

View reviewed changes

some codestyles fixes (#11498)

7d2fd04

ggazzo dismissed their stale review via 7d2fd04 July 18, 2018 19:28

ggazzo temporarily deployed to rocket-chat-pr-11441 July 18, 2018 19:28 Inactive

Fix eslint errors

896ff2c

engelgabriel deployed to rocket-chat-pr-11441 July 18, 2018 20:03 View deployment

RocketChat deleted a comment Jul 18, 2018

ggazzo approved these changes Jul 19, 2018

View reviewed changes

ggazzo merged commit f47cf2a into develop Jul 19, 2018

ggazzo deleted the fix.message-popup-mentions branch July 19, 2018 02:29

theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018

sampaiodiego mentioned this pull request Jul 28, 2018

Release 0.68.0 #11591

Merged

Provide feedback