Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click Video chat "click to join" appear "Call Already Ended" #11649

Closed
TimZhou1987 opened this issue Aug 1, 2018 · 71 comments
Closed

click Video chat "click to join" appear "Call Already Ended" #11649

TimZhou1987 opened this issue Aug 1, 2018 · 71 comments

Comments

@TimZhou1987
Copy link

TimZhou1987 commented Aug 1, 2018

Description
click to join button can't work always showing call already ended

Server Setup Information:
Version of Rocket.Chat Server: 0.63.3
Operating System: Centos 7.5
Deployment Method(snap/docker/tar/etc): docker
Number of Running Instances: 2
mongoDB Version: 3.6

Steps to Reproduce:
one user create a new video chat for sharing screen to another person
another person click the "click to join" button
always showing "call already ended"

Expected behavior:
want to connect the jitsi video chat

Relevant logs
seems rocket chat hasn't update the Jitsi timeout value. Reboot the rocketchat container will fix the issue temporary

image

@TimZhou1987 TimZhou1987 changed the title click Video chat "click to join" always appear "Call Already Ended" click Video chat "click to join" appear "Call Already Ended" Aug 1, 2018
@cfarthingale
Copy link

Experiencing a similar issue on Debian 9.

@kekscode
Copy link

Same issue using the docker container:

  • Rocket.Chat Version: 0.72.0
  • NodeJS Version: 8.11.3 - x64
  • Platform: linux
  • Process Port: 3000
  • Site URL: https://rocket.tld
  • ReplicaSet OpLog: Disabled
  • Commit Hash: abe1f41
  • Commit Branch: HEAD

@rockneverdies55
Copy link

Don't even remember since when but we're having this issue for a long time by now as of v0.74.2. Each time one of us starts a video call, "i" (info) icon has to be clicked on jitsi-meet window and meeting access link has to be copy pasted to the rocket.chat room manually for everybody to join the video meeting.

@kokotko1337
Copy link

same isue on ubuntu 16.04

@renanstn
Copy link

Same isue on manjaro.

@woulf
Copy link

woulf commented Feb 28, 2019

Same problem on one out of 3 client, using the latest desktop app on Windows 10

@woulf
Copy link

woulf commented Apr 26, 2019

Same problem on one out of 3 client, using the latest desktop app on Windows 10

one way to work around this is for the user that want to join to reclick on the "video chat" button, it will make them join the proper jitsii meeting instead of launching another one.

@lixiran
Copy link

lixiran commented Aug 6, 2019

this issue still reproduced on the latest build

@wreiske
Copy link
Contributor

wreiske commented Aug 21, 2019

Found the code:

https://github.com/RocketChat/Rocket.Chat/blame/926f629e831b21ad16567ebe3b5d2e2571a9cf89/app/videobridge/client/actionLink.js

There is a timeout that isn't getting increased. It may be better to just remove this check altogether and always open the video call, even if it may have ended.

@justinr1234
Copy link
Contributor

@wreiske can you do a PR for the fix? Thanks for finding!

@wreiske
Copy link
Contributor

wreiske commented Sep 18, 2019

@wreiske can you do a PR for the fix? Thanks for finding!

Possibly. I know @geekgonecrazy knows more about this code. Maybe some newer jitsi API updates are needed here rather than just ripping out the timer.

@bhadilov
Copy link

This bug has been killing us for 3 weeks. A fix will be greatly appreciated. :-)

@TimmiORG
Copy link

TimmiORG commented Oct 18, 2019

What is needed to get this fixed in the near future?
I would agree that the removal of the time-out would help for the moment if there is not possibility to check the usage of the room through a jitsi meet API or so.

`
actionLinks.register('joinJitsiCall', function(message, params, instance) {
if (Session.get('openedRoom')) {
const rid = Session.get('openedRoom');

	const room = Rooms.findOne({ _id: rid });
	const currentTime = new Date().getTime();
	const jitsiTimeout = new Date((room && room.jitsiTimeout) || currentTime).getTime();

	if (jitsiTimeout > currentTime) {
		instance.tabBar.open('video');
	} else {
		toastr.info(TAPi18n.__('Call Already Ended', ''));
	}

`

@ankar84
Copy link

ankar84 commented Nov 6, 2019

We have the same issue.
We have that issue in DM and in private groups\channels as well.
For example all actions a made in Winodws desktop application (Electron). But it is true and for mobile clients.
User1 press 3 dots and select Video Chat. It generates Click to Join! button in chat.
User2 in a moment press Click to Join! button and see warning Call Already Ended
User2 press 3 dots and select Video Chat and gets in User1 Jitsi Meet call.

Click to Join! button should be fixed.

@JohnLukeP
Copy link

As of today, the issue has not been solved yet. Still present on our (manually installed) environment:

Rocket.Chat Version: 2.4.2
NodeJS Version: 8.17.0 - x64
MongoDB Version: 4.0.13
Platform: linux ubuntu 18.04.3 LTS
Process Port: 3000

Tested on rocketchat webapp and rocketchat desktop app version 2.17.2

@dasfreak
Copy link

Also present on our (docker/latest) installation:

Version: 3.0.4
Node: v12.14.0
Mongo: 4.0.16

@dasfreak
Copy link

Tested on:

Desktop app version: 2.17.7
Rocket.chat. installation (manual): 3.0.3
Mongo: 4.0.16
Node: 12.16.1

The bug has disappeared and the button is showed properly.

yeah the button is there but it says "call has ended" way too fast

nick-traeger added a commit to nick-traeger/Rocket.Chat that referenced this issue Mar 22, 2020
@melroy89
Copy link

melroy89 commented Mar 24, 2020

I also hope there is a way to delete this message. Since I do not see 'Delete' menu for this kind of notifications.

While I could delete "Click to join" messages, only when I select 'Prune messages' which deletes all messages.

@bkraul
Copy link

bkraul commented Mar 25, 2020

I am a little surprised that this has been an open issue for quite sometime. We have integrated our own jitsi server and were hoping to use this functionality, but we are getting the "Call has already ended" message, which renders the whole thing worthless. Hopefully we will have a solution soon? 🙂

@ankar84
Copy link

ankar84 commented Mar 25, 2020

@bkraul as a workaround I can suggest you just to start video call as usual in chat with call already ended error. You will get video call that you need

@bkraul
Copy link

bkraul commented Mar 25, 2020

@ankar84 I am not sure I understand your message. The whole point is that it doesn't work. I can "start" the call, but the other party cannot join the call because it says "Call Already Ended". We are currently instead using the jitsi market place app that allows to start a call with /jitsi [room name]

@ankar84
Copy link

ankar84 commented Mar 25, 2020

but the other party cannot join the call because it says "Call Already Ended"

In that case other party should not press click to join button again, but they need to start video chat from chat menu. And that other party will join video chat.
We are using our own jitsi server and that workaround works like a charm.

@bkraul
Copy link

bkraul commented Mar 25, 2020

I just tested, and you are correct. It works. Not very intuitive though. I think we will stay with the slash command or the jitsi electron app for the moment. Thanks for the tip, though.

@melroy89
Copy link

So still could somebody look into a better long term solution?

@hever
Copy link

hever commented Mar 26, 2020

Joining video call sometimes work and sometimes not (Call already ended). I try to find when it's happened and I found no context. Only what coming on my mind is that there is some problem with timezones or time shifts on every clients - there might be jitsiTimeout on other history on device. But it really makes it impossible to use for many many people. And on other hand - benefit of watching timeout is near zero. So temporary disable function is the way! Do it! Somehow, please. e.g. #16966

For those who don't know what about we speaking about. There is way to do video call, so one trigger video call and other side click on in immediately and see only "Call already ended" and it does nothing. So for non tech people - video call not work.

@PotatoCarl
Copy link

We have the same problem which is really annoying. the "/Jitsi room name" works, but is kind of an annoying workaround.

@hever
Copy link

hever commented Dec 8, 2020

Until that problem will be solved, I create sed command for me to do hard fix

sed -r --in-place=.bak -e 's/;[a-z>]+(\?[^;]+"Call Already Ended")/;1\1/' /tmp/bundle/programs/web.browser/*.js

So, my update procedure run this commands (update process in Debian and manual install):

curl -L https://releases.rocket.chat/latest/download -o /tmp/rocket.chat.tgz
tar -xzf /tmp/rocket.chat.tgz -C /tmp
sed -r --in-place=.bak -e 's/;[a-z>]+(\?[^;]+"Call Already Ended")/;1\1/' /tmp/bundle/programs/web.browser/*.js
cd /tmp/bundle/programs/server && npm install

# there is time to look at warnings from npm and solving if neccesary

systemctl stop rocketchat
rm -rf /opt/Rocket.Chat
mv /tmp/bundle /opt/Rocket.Chat
chown -R rocketchat:rocketchat /opt/Rocket.Chat
systemctl start rocketchat

And if I want to look at startup process used watch systemctl status rocketchat.service

@adocampo
Copy link

Thank you @hever , I've implemented your workaround, as I used source installation as well. It's working quite well (some times it adds another "Click to Join" button, but I guess is because the other interlocutor needs to reload the client ignoring cache)

In our scenario, jitsi was working just fine until a few months ago, before the painful 3.11 and 3.12 upgrades. I remember to join a videoconference started like 30' ago without problems, just because they were still on there.

Now it appears most times the "Call already ended" message. IT guys has no further problems than grabbing the URL and paste on the chat window, but for the vast majority of users, who come from skype, this is an awkward action, when they are used to just click on a phone icon and start videoconferencing. No annoying messages, no need to invite anyone, no need to put slash commands, or copying and pasting URLs.

I wonder why a so annoying bug of 2,5 years is still present. RocketChat devs seriously needs to put some love in their customers and community members, in pandemic times videoconferencing is quite more important than other paid options RC offers, because this is a very basic feature expected to work in a modern chat, and it's in beta for a bunch of years, now.

@Bezzoom
Copy link

Bezzoom commented Apr 7, 2021

The solution offered by @hever doesn't work for my installation.
We have three nodes with same versions. 3.12.3

Does anybody have any ideas?

@AmatorPhasma
Copy link

What I wish is an option to disable this "check".
Just create a simple button with no function other than opening the call.

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Apr 17, 2021

IMO we should ignore call state on clicking the join. It's only really useful to try and keep 2 people from starting a call and it sending join message for both

@sandrotanner
Copy link

Looks like the issue worsened with a recent update (according to #21055 ) @geekgonecrazy Is it possible to maybe implement this "hack" where you disable the check in 3.14 until someone comes up with a nice PR to fix the issue?

@rasos
Copy link
Contributor

rasos commented May 17, 2021

Yes let's ignore call state when clicking on join. We don't need a check as long as it does not work properly.
After our users complained a lot we recommended them to start Jitsi Meetings by posting a message "Meet at ourjitsiserver.org/roomname" - but still several try with the phone button and fail.

@ggazzo
Copy link
Member

ggazzo commented May 25, 2021

I think that was closed by #21808 any problem please let me know

@ggazzo ggazzo closed this as completed May 25, 2021
@KodoGit
Copy link

KodoGit commented Sep 15, 2021

The problem still exists in snap version 3.17.2.

I think that was closed by #21808 any problem please let me know

@TheInfoGuru
Copy link

Still an issue on my end. Clicking on the link says call already ended, but clicking on the profile and video call still works as a workaround.

@arunodhayam10d
Copy link

Hi, I am using jitsi meet and rocket chat both in docker. I have integrated rocket chat with jitsi meet. I have put some video call just clik Clik to Join button immediately it's working. But after some time (1mins) unable to join. It shows Call ended. Pls help with this..

@jeanfbrito
Copy link
Contributor

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.

Thank you!

@camherry
Copy link

Hi,
The bug still seems to be present, I'm currently on version 4.3.2 rocket-chat docker image, and when a second participant wants to join me in video jitsi, he gets message "call already ended", so he has to click on the phone icon to join me, what generates a new button in the conversation.
Thanks for your help.

@bseclier
Copy link

Hello, can you please reopen this issue @ggazzo ?
It still doesn't work in 4.3.1 nor in 4.3.2 (docker version).
Thanks

@Sx3
Copy link

Sx3 commented Feb 8, 2022

Issue is with the Version 3.18.3

@bseclier
Copy link

bseclier commented Feb 9, 2022

Issue is still in 4.4.1...

@jeanfbrito jeanfbrito reopened this Feb 9, 2022
@brknapik
Copy link

Issue is still also in 4.1.4

@jeanfbrito
Copy link
Contributor

We are investigating this issue on Desktop App. If it happens outside the desktop app, please let us know.

@KodoGit
Copy link

KodoGit commented Feb 22, 2022

Desktop Browser version too.

@bseclier
Copy link

Thank you @jeanfbrito
As I said in #23904, I have no problem with firefox nor chromium, only in the desktop app.

@dougfabris
Copy link
Member

dougfabris commented Nov 11, 2022

Closing this stale issue because changed how the message works in video conferences since the latest major release #25570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests