-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAK] VideoConference #25570
Merged
Merged
[BREAK] VideoConference #25570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [NEW] 'video-conference/start' endpoint and direct call negotiation
* [NEW] [VideoConference] System Messages
* [NEW] Video Conference Model Co-authored-by: Diego Sampaio <chinello@gmail.com>
* feat: StartVideoConfModal * new: ui-video-conf * fix review * Merge branch 'new/videoconf' into new/startVideoConfModal * fix: ControllerButton & FooterButton * fix: review * chore: fix types * fix: review * chore: toolbox order Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* new: video conf popup * new: ReceivingPopup * new: TimedVideoConfPopup * improve: VideoConfModal components * chore: lint
* [NEW] VideoConf: Join Direct Call
* new: JoinVideoConfModal * chore: remove mocked modal action
* [NEW] VideoConf: Join Direct Call * Cancel endpoint * Model operations * Renamed operations * Reorganizing document creation * name * invert params * Missing file * setEndedById * [NEW] [VideoConference] Group VideoConferences
kodiakhq
bot
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Jun 30, 2022
This PR currently has a merge conflict. Please resolve this and then re-add the |
kodiakhq
bot
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Jul 1, 2022
This PR currently has a merge conflict. Please resolve this and then re-add the |
d-gubert
previously approved these changes
Jul 1, 2022
* chore: remove VideoConfModal * new: ui improves * chore: conf list improves * new: StartCallPopup * new: videoconf general flow improves * Fix acceptance validation * Prevent multiple incoming calls from the same user. * chore: IconButton variant * chore: license tweak * chore: hide undefined lastUpdated on AppDetailsHeader * Stop triggering invalid ui-kit interaction when clicking on the join button * Keep user's name and username on old video conferences up to date * Renamed video conference to conference calls * Anticipating changes for anonymous users * Chore: Allow endpoints to optionally require authentication depending on anonymous reading being enabled or not. * Chore: Room access validation may be called without user information * adjustment * Anonymous users * missing i18n key * Keep track of anonymous users * Rate Limiter * Fixed conditional param * Remove join button from old calls * Changed error message * Remove join button from manually ended calls too Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
d-gubert
approved these changes
Jul 1, 2022
ggazzo
approved these changes
Jul 1, 2022
pierre-lehnen-rc
approved these changes
Jul 1, 2022
gabriellsh
added a commit
that referenced
this pull request
Jul 4, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) Chore: move fork of cas module to the monorepo (#26107) Chore: Add Agenda fork to the monorepo (#25681) Chore: Bump deps (#25624) [NEW][ENTERPRISE] Device Management (#25791) Chore: `refactor/tsc-perf` (#26040) [BREAK] Upgrade to version 5.0 can be done only from version 4.x (#26100) [BREAK] Remove support to old MongoDB versions (#26098) [NEW] Matrix Federation UX improvements (#25847) Regression: en.i18n.json spaces [NEW][ENTERPRISE] Introducing dial pad component into sidebar, calls table, contextual bar (#26081) Chore: Settings UI issue (#26053) Chore: Adding default message parser template (#26064) Regression: [VideoConference] If the caller loses connection, direct calls are never canceled (#26099) Chore: Handle errors on index creation (#26094) Chore: fix watermark condition (#26095) [FIX] Validate room access (#24534) [BREAK] VideoConference (#25570) [FIX] Undefined headers on API Client (#26083) Regression: Add Error boundary to katex render component (#26067) Chore: Allow endpoints to optionally require authentication (#26084) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
In this PR we're deprecating the Video Conference functionality from the core of the application and introducing a new video conference flow:
Now the video conference feature will be agnostic so you'll be able to set the provider such as Jisti and BBB as apps from our marketplace:
Video conferences settings are now global, allowing you to set the default provider
[Enterprise Features]
Enterprise Providers: Google Meet and Pexip
Calls List
Issue(s)
Steps to test or reproduce
Further comments