Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Multiple slackbridges #11346

Merged
merged 30 commits into from
Apr 25, 2019
Merged

[NEW] Multiple slackbridges #11346

merged 30 commits into from
Apr 25, 2019

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented Jul 4, 2018

Closes #9339

This PR adds support for multiple slack bridges on the same RC server.

@Hudell Hudell self-assigned this Jul 4, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11346 July 4, 2018 19:19 Inactive
@smellems
Copy link

smellems commented Jul 5, 2018

Thanks @Hudell! This is related to #10915 as well.

Question: how will this work where channels in multiple Slackbridges have the same name? ex.: #general

Right now, channels names have to match in Rocket.Chat and Slack for the bridge to work.

@Hudell
Copy link
Contributor Author

Hudell commented Jul 5, 2018

Channel names still need to match. If there are two slackbridges with a channel with the same name, both will work together in the same RC channel. However, Rocket.Chat will not send messages received from one Slackbridge to the others.

@creaux
Copy link

creaux commented Aug 24, 2018

What left on this PR?

@Hudell
Copy link
Contributor Author

Hudell commented Aug 24, 2018

The only thing missing is an area on the administration center to configure multiple slack servers.

@TimHarrison
Copy link

Any update on the build out of the admin setting page to complete this effort? It's been over a month since any visible progress was made on this feature. By the sounds of it, this feature is highly desirable by many people and organizations, including me. I'm sure the completion of this feature would make a lot of people happy!

@Sing-Li
Copy link
Member

Sing-Li commented Sep 30, 2018

@TimHarrison We are making some overhauling changes ("improvements") on the Admin UI and the remaining work on this PR hinges indirectly on it.

@TimHarrison @creaux One solution to enable some of you to move forward with this -- is to enable configuration via some hard code in the meantime. Are you guys on a fork that you can pull down this PR and work with us to make it work for you? [anyone else in such a position and wants to be early adopters - please also comment here] Thanks.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11346 October 3, 2018 18:29 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11346 October 3, 2018 18:31 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11346 October 3, 2018 20:10 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11346 October 3, 2018 20:17 Inactive
@Hudell
Copy link
Contributor Author

Hudell commented Oct 3, 2018

I changed the API Token setting to accept multiple lines, so you can add as many API tokens as you need and RC will connect to each of them individually. With this, there's no need to change any code to test the multiple slack bridges.

@Hudell Hudell added this to the 0.72.0 milestone Nov 7, 2018
@Ismaw34
Copy link
Contributor

Ismaw34 commented Nov 19, 2018

Maybe this PR #12213 could be added to this?

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11346 November 19, 2018 12:33 Inactive
@Hudell Hudell changed the title [WIP] [NEW] Multiple slackbridges [NEW] Multiple slackbridges Apr 25, 2019
@engelgabriel engelgabriel modified the milestones: Short-term, 1.0.0 Apr 25, 2019
@rodrigok rodrigok merged commit b20e3d3 into develop Apr 25, 2019
@rodrigok rodrigok deleted the multiple-slackbridges branch April 25, 2019 18:40
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple SlackBridge configurations