Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixed SlackBridge Private Channels #12213

Closed
wants to merge 6 commits into from
Closed

[FIX] Fixed SlackBridge Private Channels #12213

wants to merge 6 commits into from

Conversation

Ismaw34
Copy link
Contributor

@Ismaw34 Ismaw34 commented Sep 28, 2018

Closes #11485
Maybe closes others

Slack Api changed the way that the channels were accessed, now the private channels must be accessed with other api calls and with args.

The bug was:
Slack to RocketChat: Works, private or public channels.
RocketChat to Slack: No message was sent if the Slack channel was private. Public channels are OK.

@Hudell Hudell self-assigned this Nov 19, 2018
@nylen
Copy link

nylen commented Jan 25, 2019

Note: conversations.info is not a one-to-one replacement for channels.info! In particular conversations.info does not have the members key - this requires a separate API call.

See #13261 for more details. That PR probably does not fix this issue - what we were seeing was slightly different than what was reported here.

@engelgabriel engelgabriel added this to the 1.0.0 milestone Apr 25, 2019
@engelgabriel engelgabriel requested a review from Hudell April 25, 2019 18:33
@Hudell
Copy link
Contributor

Hudell commented Apr 27, 2019

Fixed on #14273

@Hudell Hudell closed this Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SlackBridge only working one-way on private channels after restart.
5 participants