Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: hiding reset button for readonly fields #14025

Merged
merged 2 commits into from
Apr 7, 2019
Merged

Settings: hiding reset button for readonly fields #14025

merged 2 commits into from
Apr 7, 2019

Conversation

alansikora
Copy link
Contributor

No description provided.

@alansikora alansikora self-assigned this Apr 6, 2019
@alansikora alansikora requested a review from sampaiodiego April 6, 2019 19:36
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-14025 April 6, 2019 19:37 Inactive
@alansikora alansikora mentioned this pull request Apr 6, 2019
Merged
@engelgabriel engelgabriel added this to the 1.0.0 milestone Apr 6, 2019
@engelgabriel engelgabriel merged commit fede7cf into develop Apr 7, 2019
@engelgabriel engelgabriel deleted the hide-reset-readonly branch April 7, 2019 00:52
wreiske added a commit to wreiske/Rocket.Chat that referenced this pull request Apr 7, 2019
@wreiske
Merge branch 'emoji-upgrades' of https://github.com/wreiske/Rocket.Chat…
592a4e8 
… into emoji-upgrades

* 'emoji-upgrades' of https://github.com/wreiske/Rocket.Chat:
  Settings: disable reset button (RocketChat#14026)
  Settings: hiding  reset button for readonly fields (RocketChat#14025)
  [NEW] Add support to updatedSince parameter in emoji-custom.list and deprecated old endpoint (RocketChat#13510)
  [IMPROVE] Add permission to change other user profile avatar (RocketChat#13884)
  [IMPROVE] UI of Permissions page (RocketChat#13732)
  [NEW] Chatpal: Enable custom search parameters (RocketChat#13828) (RocketChat#13829)
  [FIX] Closing sidebar when room menu is clicked. (RocketChat#13842)
  [FIX] Check settings for name requirement before validating (RocketChat#14021)
  Fix debug logging not being enabled by the setting (RocketChat#13979)
  [FIX] Links and upload paths when running in a subdir (RocketChat#13982)
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

@alansikora alansikora

Labels
feat: app settings
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alansikora @engelgabriel