-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Sort channel directory listing by latest message #16604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sampaiodiego, please review this! |
gabriellsh
previously approved these changes
Feb 27, 2020
@gabriellsh Does this pr is in a state to merge? Should I rebase to the current state so that this pr will be merged? |
@ggazzo @gabriellsh please comment^ |
sampaiodiego
changed the title
[FIX] sort channel directory listing by latest message
[NEW] Sort channel directory listing by latest message
Mar 26, 2020
sampaiodiego
approved these changes
Mar 26, 2020
gabriellsh
added a commit
that referenced
this pull request
Mar 26, 2020
…/react-root * 'develop' of github.com:RocketChat/Rocket.Chat: (76 commits) Regression: Fix issue with opening rooms (#17028) Group DM improvements [NEW] Sort channel directory listing by latest message (#16604) [FIX] Wrong message count statistics in Admin info page (#16680) Fix: 2FA DDP method not getting code on API call that doesn’t requires 2FA (#16998) [NEW] Direct message between multiple users (#16761) Bump version to 3.0.7 Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription (#17017) Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription (#17017) Bump version to 3.0.6 [Regression] Replace the Omnichannel queue model observe with Stream (#16999) [FIX] Keeps the agent in the room after accepting a new Omnichannel request (#16787) [Regression] Replace the Omnichannel queue model observe with Stream (#16999) [NEW] Engagement Dashboard (#16960) Fix StreamCast info (#16995) [IMPROVE] Ability to change offline message button link on emails notifications (#16784) Bump version to 3.0.5 [FIX] Race conditions on/before login (#16989) [FIX] Race conditions on/before login (#16989) Fix: StreamCast was not working correctly (#16983) ...
Hi, thank you for this PR ! Do you think it's possible to make this also for the "topic" column ? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #11951
Currently, In the "Directory" for a Rocket.chat instance the channels can be sorted by "Name", "Users", and "Created At". Now by clicking on the Last Message field, we can sort the channels in ascending/descending order.
@sampaiodiego, please review:)