Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription #17017

Merged

Conversation

renatobecker
Copy link
Contributor

The Omnichannel setting -> Livechat_enable_inquiry_fetch_by_stream is no longer necessary since we removed the subscription that was used to fetch the queue data from the client-side.
Now, the Omnichannel queue works through the stream approach, only.

@renatobecker renatobecker added this to the 3.1.0 milestone Mar 25, 2020
@renatobecker renatobecker requested a review from rodrigok March 25, 2020 21:30
@sampaiodiego sampaiodiego merged commit e16ef75 into develop Mar 25, 2020
@sampaiodiego sampaiodiego deleted the omnichannel/remove-deprecated-omnichannel-setting branch March 25, 2020 22:26
sampaiodiego pushed a commit that referenced this pull request Mar 25, 2020
…ueue data through subscription (#17017)

* Removed deprecated omnichannel setting,

* Remove unnecessary setting creation.

* Add method to clear the inquiry collection on client-side before set up the stream.
@sampaiodiego sampaiodiego mentioned this pull request Mar 25, 2020
gabriellsh added a commit that referenced this pull request Mar 26, 2020
…/react-root

* 'develop' of github.com:RocketChat/Rocket.Chat: (76 commits)
  Regression: Fix issue with opening rooms (#17028)
  Group DM improvements
  [NEW] Sort channel directory listing by latest message (#16604)
  [FIX] Wrong message count statistics in Admin info page (#16680)
  Fix: 2FA DDP method not getting code on API call that doesn’t requires 2FA (#16998)
  [NEW] Direct message between multiple users (#16761)
  Bump version to 3.0.7
  Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription  (#17017)
  Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription  (#17017)
  Bump version to 3.0.6
  [Regression] Replace the Omnichannel queue model observe with Stream (#16999)
  [FIX]  Keeps the agent in the room after accepting a new Omnichannel request (#16787)
  [Regression] Replace the Omnichannel queue model observe with Stream (#16999)
  [NEW] Engagement Dashboard (#16960)
  Fix StreamCast info (#16995)
  [IMPROVE] Ability to change offline message button link on emails notifications (#16784)
  Bump version to 3.0.5
  [FIX] Race conditions on/before login (#16989)
  [FIX] Race conditions on/before login (#16989)
  Fix: StreamCast was not working correctly (#16983)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants