Regression: Overwrite model functions on EE only when license applied #17061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert and fixes 1 when merging 612a0f2 into 7f7a551 - view on LGTM.com new alerts:
fixed alerts:
|
rodrigok
approved these changes
Mar 29, 2020
ggazzo
added a commit
that referenced
this pull request
Mar 30, 2020
…to feat/directory * 'feat/directory' of github.com:RocketChat/Rocket.Chat: Add bio as default field for searching Remove topic column from users tab Featured on top always [NEW] Home button on sidebar (#17052) [IMPROVE] Repeat “Reply In Thread” and “Add Reaction” inside the message actions menu (#17073) Make DirectMessageRoomType.isGroupChat() accept null roomData (#17074) [IMPROVE] Tab Bar actions reorder (#17072) Regression: Overwrite model functions on EE only when license applied (#17061) Regression: users.setStatus throwing an error if message is empty (#17036) Regression: Omnichannel notification on new conversations displaying incorrect information (#16346)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current EE code was overriding model functions without checking if an EE license is applied.
I've also changed debug calls with
JSON.stringifyto a callback function, soJSON.stringifyisn't called without showing the log.