Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Broken Search if users without DM subscriptions are listed #17074

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

tassoevan
Copy link
Contributor

An error was thrown when getting the avatars and listing the chat room items of search results.

@tassoevan tassoevan added this to the 3.1.0 milestone Mar 29, 2020
@tassoevan tassoevan requested review from rodrigok and ggazzo March 29, 2020 19:54
@rodrigok rodrigok changed the title [FIX] Broken Search if users without DM subscriptions are listed Regression: Broken Search if users without DM subscriptions are listed Mar 29, 2020
@rodrigok rodrigok merged commit d83d6ca into develop Mar 29, 2020
@rodrigok rodrigok deleted the fix/global-search branch March 29, 2020 20:19
ggazzo added a commit that referenced this pull request Mar 30, 2020
…to feat/directory

* 'feat/directory' of github.com:RocketChat/Rocket.Chat:
  Add bio as default field for searching
  Remove topic column from users tab
  Featured on top always
  [NEW] Home button on sidebar (#17052)
  [IMPROVE] Repeat “Reply In Thread” and “Add Reaction” inside the message actions menu (#17073)
  Make DirectMessageRoomType.isGroupChat() accept null roomData (#17074)
  [IMPROVE] Tab Bar actions reorder (#17072)
  Regression: Overwrite model functions on EE only when license applied (#17061)
  Regression: users.setStatus throwing an error if message is empty (#17036)
  Regression: Omnichannel notification on new conversations displaying incorrect information (#16346)
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants