Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA] Add Share Functionality #17649

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Shailesh351
Copy link
Contributor

@Shailesh351 Shailesh351 commented May 14, 2020

This is 8th Feature of https://github.com/WideChat/Rocket.Chat/wiki/PWA-features to integrate PWA functionality in RC.

The goal of this PR is to add Share functionality to make RC on Mobile device to give similar experience as Native App.

localhost_3000_channel_general(Pixel 2 XL) (1)
localhost_3000_channel_general(Pixel 2 XL)
localhost_3000_channel_general(Pixel 2 XL) (2)

Native Share demo from Viasat server because it need https

Screenshot_1589459408

@engelgabriel
Copy link
Member

I can understand the funtionality of SHARGING a channel or a message, and we will merge it, but I am not sure I understand what the sharing button does on the room list view bellow:

image

@engelgabriel engelgabriel added this to the 4.0.0 milestone Sep 23, 2020
@engelgabriel engelgabriel requested a review from ggazzo September 23, 2020 16:32
@Shailesh351
Copy link
Contributor Author

@engelgabriel The sharing option in the room list is for sharing app with other people. It will contain link to direct message the logged in user. i.e. https://domain.com/direct/{myUsername}. So that new user will directly register and start chatting with me with that link

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants