[Upstream PWA] #17649 Add Share Functionality #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shailesh351 your GIF shows "Viasat Connect is a new application that..." But these PRs and branches should have nothing Viasat specific in them. Can you verify that that is the case please? Oh..... I see...... this is an image from dev.veranda, because we don't have a full PWA branch yet.... Maybe when we put it all together we can make sure that any images that go along with the Upstream PRs are drawn from our pwa_demo feature branch. |
|
Yes @ear-dev. Native share only works with https. So for demo purpose I have added screenshot from our dev veranda server. I should mention that in PR. Will do it 👍 |
|
Got it. When we standup our feature branch it will be https. So perhaps we take new images for all the PRs then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of Upstream PWA PR : RocketChat#17649
This is 8th Feature of https://github.com/WideChat/Rocket.Chat/wiki/PWA-features to integrate PWA functionality in RC.
The goal of this PR is to add Share functionality to make RC on Mobile device to give similar experience as Native App.
Native Share demo from Viasat server because it need https