Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Geolocation permission being asked on load #18030

Merged
merged 3 commits into from
Jun 30, 2020
Merged

[FIX] Geolocation permission being asked on load #18030

merged 3 commits into from
Jun 30, 2020

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jun 23, 2020 •
edited
Loading

Proposed changes

Location is now only requested when the button is pressed. Added warning when permission is denied.

Issue(s)

Closes #3991

How to test or reproduce

Screenshots

image
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@gabriellsh
Ask for permission only when button is clicked
d810aa5
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
98f02e9 
…geolocation_permission

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Deprecate check permission on integrations (#18024)
  Regression: Favorite and Featured fields not triggering changes (#18010)
  Regression: Fix setting reply-to email header (#18008)
@gabriellsh
Permission prompt modal
90b3d06
@ggazzo ggazzo added this to the 3.5.0 milestone Jun 29, 2020
@ggazzo ggazzo requested a review from a team June 29, 2020 13:10
@ggazzo ggazzo merged commit 98a935d into develop Jun 30, 2020
@ggazzo ggazzo deleted the fix/geolocation_permission branch June 30, 2020 23:18
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Do not ask for location on load
2 participants
@gabriellsh @ggazzo