-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Rewrite Announcement as React component #20172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rewrite-announcement * 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits) Regression: Info Page Icon style and usage graph breaking (#20180) Chore: Change console.warning() to console.warn() (#20200) [FIX] Room's list showing all rooms with same name (#20176) Regression: Change sort icon (#20177) [FIX] Wrong userId when open own user profile (#20181) [FIX] Livechat.RegisterGuest method removing unset fields (#20124) [IMPROVE] Rewrite Prune Messages as React component (#19900) [FIX] Change header's favorite icon to filled star (#20174) [FIX] Initial values update on Account Preferences (#19938) [FIX] Unable to reset password by Email if upper case character is present (#19643) [FIX] Video call message not translated (#18722) [NEW] Server Info page (#19517) [IMPROVE] Title for user avatar buttons (#20083) [FIX] Admin User Info email verified status (#20110) [IMPROVE] Tooltip added for Kebab menu on chat header (#20116) [FIX] Translate keyword for 'Showing results of' in tables (#20134) [FIX] Markdown added for Header Room topic (#20021) [FIX] Status circle in profile section (#20016) [FIX] Normalize messages for users in endpoint chat.getStarredMessages (#19962) [FIX] minWidth in FileIcon to prevent layout to broke (#19942) ...
gabriellsh
requested changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gabriellsh
requested changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no announcement, and one is added, it's necessary to refresh the page for it to appear.
gabriellsh
reviewed
Jan 14, 2021
ggazzo
approved these changes
Jan 19, 2021
ggazzo
approved these changes
Jan 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Before:
After:
Issue(s)
Steps to test or reproduce
Further comments