[FIX] Add debouncing to add users search field. #20297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Darshilp326 Very nice mate, thanks for that! I think, maybe 1000ms is too much long, can we try 500/600 ms? |
|
@dougfabris I tried with 500ms but we usually have that much gap while typing. |
dougfabris
changed the title
dougfabris
approved these changes
Jan 22, 2021
dougfabris
approved these changes
Jan 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added debouncing to that search field so after every key stroke API is not called.
BEFORE
add-user-issue.mp4
AFTER
Add-user-pr.mp4
Issue(s)
Closes #20263
Steps to test or reproduce
Further comments