Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite: CreateChannel modal component #20617

Merged
merged 16 commits into from
Feb 9, 2021
Merged

Rewrite: CreateChannel modal component #20617

merged 16 commits into from
Feb 9, 2021

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Feb 5, 2021 •
edited
Loading

Proposed changes (including videos or screenshots)

image

Issue(s)

Steps to test or reproduce

Further comments

@tiagoevanp tiagoevanp requested a review from a team February 5, 2021 16:10
gabriellsh
gabriellsh requested changes Feb 5, 2021
View reviewed changes
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I noticed is that whenever I create a new channel, if I mark it as public && broadcast, it creates a readonly channel, but not a broadcast one. If I create it as a private group, it is created as broadcast.

@ggazzo ggazzo requested review from gabriellsh and a team February 8, 2021 13:08
@ggazzo ggazzo changed the title Rewrite: Sidebar CreateChannel modal component Rewrite: CreateChannel modal component Feb 8, 2021
gabriellsh
gabriellsh previously approved these changes Feb 8, 2021
View reviewed changes
@ggazzo ggazzo merged commit 2ad2d0b into develop Feb 9, 2021
@ggazzo ggazzo deleted the rewrite/create-channel branch February 9, 2021 16:45
@yash-rajpal yash-rajpal mentioned this pull request Feb 15, 2021
Merged
6 tasks
@yash-rajpal
Copy link
Member

@ggazzo @tiagoevanp
This PR deleted a meteor template named tag , this template is being used when creating direct messages and discussions.

Please see issue #20771

Please review PR #20772 , this PR adds back this template.
Thanks :)

@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@gabriellsh gabriellsh gabriellsh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiagoevanp @yash-rajpal @ggazzo @gabriellsh @MartinSchoeler