Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Adding the accidentally deleted tag template, used by other templates #20772

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Feb 15, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Adding back accidentally deleted tag Template.

Issue(s)

fixes #20771
closes #20777

Steps to test or reproduce

Further comments

fix-tag-after

PR #20617 ports previously written meteor templates to React, it also deletes a template tag being used by other templates which causes an error while creating discussions and direct messages.
This pr solves this by adding back tag template.

@ggazzo ggazzo merged commit 097f291 into RocketChat:develop Feb 19, 2021
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants