Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Add default permission 'start-discussion' and 'start-discussion-other-user' to app user #22577

Merged
merged 7 commits into from
Aug 23, 2021

Conversation

marceloschmidt
Copy link
Member

Proposed changes (including videos or screenshots)

Adding the start-discussion permission to App in order to allow apps to start discussions without requiring admins to manually enable that permission.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team July 5, 2021 13:58
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a migration to apply to existing roles

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 1 .js files, please convert to ts(x).
server/startup/migrations/v230.js

@github-actions github-actions bot dismissed their stale review August 23, 2021 18:48

js files removed

@sampaiodiego sampaiodiego merged commit 0c75472 into develop Aug 23, 2021
@sampaiodiego sampaiodiego deleted the add-discussion-permission-to-app branch August 23, 2021 19:52
@sampaiodiego sampaiodiego mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants