Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.18.0 #23066

Merged
merged 83 commits into from
Aug 31, 2021
Merged

Release 3.18.0 #23066

merged 83 commits into from
Aug 31, 2021

Conversation

sampaiodiego
Copy link
Member

2021-08-30 · 5 🎉 · 7 🚀 · 20 🐛 · 18 🔍 · 25 👩‍💻👨‍💻

Engine versions

  • Node: 12.22.1
  • NPM: 6.14.1
  • MongoDB: 3.4, 3.6, 4.0, 4.2
  • Apps-Engine: 1.27.1

🎉 New features

  • ENTERPRISE: Maximum waiting time for chats in Omnichannel queue (#22955)

    • Add new settings to support closing chats that have been too long on waiting queue

    • Moved old settings to new "Queue Management" section

    • Fix issue when closing a livechat room that caused client to not to know if room was open or not

  • Banner for the updates regarding authentication services (#23055)

    Add a banner to inform admins about future authentication changes. This banner targets servers that use some sort of authentication service since they're the ones which this update concerns the most.

  • Report "Read Receipts" setting on stat collector (#23033)

  • REST endpoint to delete a DM and allow DM for two other users (#18022 by @abrom)

    [NEW] Improve DM create/delete API management

  • Separate RegEx Settings for Channels and Usernames validation (#21937 by @aditya-mitra)

    Now, there are 2 separate settings for validating names - One for channels and another for usernames.

    This change also removes the old UTF8_Names_Validation setting and adds 2 new settings UTF8_User_Names_Validation and UTF8_Channel_Names_Validation.

    new.seperate.regex.settings.2.mp4

🚀 Improvements

  • Add default permission 'start-discussion' and 'start-discussion-other-user' to app user (#22577)

  • Create thumbnails from uploaded images (#20907)

  • Exclude archived rooms from unread-message count (#22515 by @nmagedman)

  • Increase the verbosity of Omnichannel routing system debugging outputs (#22977)

  • Rewrite File Upload Modal (#22750)

    Image preview:
    image

    Video preview:
    image

    Files larger than 10mb:
    image

  • Types from currentChatsPage.tsx (#22967)

  • Use tag autocomplete in more places (#22902)

    Use the proper autocomplete component for omnichannel tags, this adds proper sorting of results and better consistency.

🐛 Bug fixes

  • "Read Only" field description is incorrect when the option is checked (#21868 by @epif4nio)

  • "Users By Time of the Day" chart displays incorrect data for Local Timezone (#22836)

    • Add local timezone conversion to the "Users By Time of the Day" chart in the Engagement Dashboard;
    • Simplify date creations by using endOf and startOf methods.
  • Atlassian Crowd connection not working (#22996 by @piotrkochan)

  • Audio recording doesn't stop in direct messages on channel switch (#22880)

    • Cancel audio recordings on message bar destroy event.
      test-22372
  • Bad words falling if message is empty (#22930)

  • Broken download link on uploaded files (#22848)

    Uploaded files had wrong download links when the deploy had a sub directory. This misbehavior was caused by the wrong usage of the rtrim method, the 2nd parameter is a list of chars, not a string (this method was inspired by php)

  • Can't access other administration menus after opening Engagement Dashboard (#22870)

  • Go command duplicating subfolder path on iframes. (#22796)

  • Manually approve new users is not applied to SAML users (#22823)

  • Production-environment dependencies (#22868)

    @rocket.chat/icons was incorrectly referred as development dependency.

  • QuickActions for mobile screen (#23016)

  • Registration not possible with TOTP and email verification (#22778)

  • Return transcript/dashboards based on timezone settings (#22850)

    • Added new setting to manage timezones

    • Applied new setting to omnichannel dashboards (realtime, analytics) [NOTE: Other dashboards aren't using this setting actually)

    • Change getAnalyticsBetweenDate query to filter out system messages instead of substracting them

  • Tab margin style (#22851)

    before

    image

    after

    image

  • Threads and discussions searches don't display proper results (#22914)

    • Fix issue in discussions search (which wasn't working after a search with no results was made);
    • Improve discussions and threads searches: both searches (chat.getDiscussions and chat.getThreadsList) are now case insensitive (do NOT differ capital from lower letters) and match incomplete words or terms.
  • Threads List being requested more than expected (#22879)

  • TypeError on Callout type prop (#22790 by @hrahul2605)

  • User is still asked for 2FA confirmation even if it is deactivated (#22801)

  • User presence being processes even if presence monitor was disabled (#22927)

  • users registered via third party apps bypass custom required fields (#22396)

    moves the custom fields from the initial registration form to the "pick a username" screen so that everyone is forced to fill the custom required fields

🔍 Minor changes
  • Chore: Enable husky pre-push hook (back again) (#22994)

  • Chore: Fix RHEL container build issue due to gpg keyserver deprecation (#22672 by @jsm84)

    Changed gpg keyserver in RHEL Dockerfile to openpgp.org due to deprecation of the SKS keyserver network.

  • Chore: Fix typo in rtl.css (#22431 by @eltociear)

  • Chore: Prevent new JS files being added (#22972)

    We are moving our code base to TS, one way to help developers remember this is create a task that will notify you every time a new file is created.

  • Chore: Script to start Rocket.Chat in HA mode during development (#22398)

    Sometimes we need to start Rocket.Chat in High-Availability mode (cluster) during development to test how a feature behaves or hunt down a bug. Currently, this involves a lot of commands with details that might be lost if you haven't done it in a while.

    This PR intends to provide a really simple way for us to start many instances of Rocket.Chat connected in a cluster.

  • Chore: Update Livechat widget to 1.9.4 (#22990)

  • i18n: Language update from LingoHub 🤖 on 2021-08-09Z (#22888)

  • i18n: Language update from LingoHub 🤖 on 2021-08-16Z (#22937)

  • i18n: Language update from LingoHub 🤖 on 2021-08-23Z (#23007)

  • Merge master into develop & Set version to 3.18.0-develop (#22834)

  • Regression: Attachment not rendering on message (#23046)

  • Regression: File upload name suggestion (#22953)

    Before:
    image
    image

    After:
    image
    image

  • Regression: Fix creation of self-DMs (#23015)

  • Regression: Logs were missing from Omnichannel callback methods (#23048)

  • Regression: no-js-action bump version (#22997)

  • Regression: readNow blocked by a invalid condition (#22952)

  • Release 3.17.1 (#22942)

  • Release 3.17.2 (#23045)

👩‍💻👨‍💻 Contributors 😍

👩‍💻👨‍💻 Core Team 🤓

hrahul2605 and others added 30 commits August 2, 2021 11:26
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
Merge master into develop & Set version to 3.18.0-develop
* Fix scroll on discussion and thread lists

* chore: update fuselage

Co-authored-by: dougfabris <devfabris@gmail.com>
Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
* Move deps from devDeps

* Upgrade Storybook

* Sort dependencies

* Rollback @rocket.chat/livechat as dev dependency

Co-authored-by: dougfabris <devfabris@gmail.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
… New Users section contains undefined data (#22862)

* Fix download content and add headers to download files

* Update date format

Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
…rs in the room (#22871)

* Fix room.muted undefined error

* Remove unnecessary includes function calls

Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
…elds (#22396)

* copy custom field logic to username screen

* remove login state from username screen

* remove custom fields from initial registration form

* add saveCustomFields method

* skip custom fields in register user method

* remove console logs

* add method call in username form

Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
)

Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
…y deactivated. (#22801)

Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com>
* switched from rtrim to replace

* removed subdirectory start

* added regex to string.replace

* added regex to string.replace

* proper user of scape regex

* removed logging statement
* Fix message update not working

* resolve room object only if required + only add canned-responses-replace-placeholders when the canned-response feature is on

Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>
…#22839)

* Fix Chat Transfer Failure due to Unrecognized stage name departmentId

* Fix applyChatRestictions callback not returing proper value for community version

Co-authored-by: Shailesh Baldaniya <shaileshbaldaniya351@gmail.com>
* fixed SAML login with manually activate user flag

* small fix
* Language update from LingoHub 🤖

Project Name: Rocket.Chat
Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat
User: Robot LingoHub

Easy language translations with LingoHub 🚀

* Update vars

* Update bn-IN.i18n.json

Co-authored-by: Robot LingoHub <robot@lingohub.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
…ent Dashboard's Active Users section (#22849)

* Fix download content and add headers to download files

* Merge DAU, WAU and MAU data in a single file

* Update date format

Co-authored-by: dougfabris <devfabris@gmail.com>
Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
 * Cancel audio recordings on message bar destroy event.

Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
* fix: modal and sidebar footer styles on IE

* chore: update fuselage

* fix: review

Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
hte -> the

Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
…hecked (#21868)

 * Update "Read Only" field description when the option is checked in channel's creation.

Co-authored-by: dougfabris <devfabris@gmail.com>
…t Dashboard (#22870)

* fixed engagement dashboard tab exit

* undo unnecessary changes

* removed unused import
Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
* Image upload preview

* Finished file upload modal

* Fix image preview size

* Fix image aspect ratio

* remove preview from ie11

* fix toast

* remove multiplication

* Fix scroll

* fix: conditional ImagePreview return

* Fix filetype undefined

* Fix preview infinite loading

Co-authored-by: dougfabris <devfabris@gmail.com>
* close omnichannel conversations when agent is deactivated

* Remove console.log

* remove unnecesary props from type

* Update app/lib/server/functions/setUserActiveStatus.js

Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>

Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
lingohub bot and others added 20 commits August 23, 2021 13:56
Project Name: Rocket.Chat
Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat
User: Robot LingoHub

Easy language translations with LingoHub 🚀

Co-authored-by: Robot LingoHub <robot@lingohub.com>
…sion-other-user' to app user (#22577)

Co-authored-by: Diego Sampaio <chinello@gmail.com>
* WIP

* Fix WIP

* Fix

* lint

* use filtered action

* fix actions in mobile

Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
…22914)

* Fix issue in discussions search (which wasn't working after a search with no results was made)

* Improve discussions and threads searches: both searches (`chat.getDiscussions` and `chat.getThreadsList`) are now case insensitive (do NOT differ capital from lower letters) and match incomplete words or terms
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* Fix autoselection algorithm on community

* change query to avoid marking users as unavailable

* Apply fix to query when user setting is empty string

Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
* Add missing logs to callbacks. Add log when callback is being called

* Add missing semicolon

* Add more context to some callbacks and extra logs
@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2021

This pull request fixes 1 alert when merging 589f202 into fe0e5e4 - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

@sampaiodiego sampaiodiego merged commit a57b10e into master Aug 31, 2021
@sampaiodiego sampaiodiego deleted the release-3.18.0 branch August 31, 2021 03:33
@lgtm-com
Copy link

lgtm-com bot commented Aug 31, 2021

This pull request fixes 1 alert when merging 47cced0 into fe0e5e4 - view on LGTM.com

fixed alerts:

  • 1 for Superfluous trailing arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.