Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] "Users By Time of the Day" chart displays incorrect data for Local Timezone #22836

Merged
merged 4 commits into from
Aug 5, 2021

Conversation

matheusbsilva137
Copy link
Member

Proposed changes (including videos or screenshots)

  • Add local timezone conversion to the "Users By Time of the Day" chart in the Engagement Dashboard;
  • Simplify date creations by using endOf and startOf methods.

Issue(s)

Task - ClickUp

Steps to test or reproduce

Access Administration > Engagement Dashboard.

Further comments

Sessions' timestamps are stored in the database in UTC, then only local timezone might require date conversions.

@matheusbsilva137 matheusbsilva137 merged commit 1f185f6 into develop Aug 5, 2021
@matheusbsilva137 matheusbsilva137 deleted the fix/users-by-time-of-day branch August 5, 2021 20:11
gabriellsh added a commit that referenced this pull request Aug 10, 2021
* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Manually approve new users is not applied to SAML users (#22823)
  [FIX] applyChatRestictions callback not working for community version (#22839)
  [FIX] Message update not working in some cases (#22856)
  [FIX] Broken download link on uploaded files (#22848)
  [FIX] User is still asked for 2FA confirmation even if 2FA is globally deactivated. (#22801)
  [FIX] Registration not possible with TOTP and email verification (#22778)
  [FIX] users registered via third party apps bypass custom required fields (#22396)
  [FIX] "Click to Join" button is not working if there are no muted users in the room (#22871)
  [BREAK][ENTERPRISE] CSV file downloaded in the Engagement Dashboard's New Users section contains undefined data (#22862)
  Fix Local time conversion in the Users By Time of the Day chart (#22836)
@sampaiodiego sampaiodiego mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants