Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Return transcript/dashboards based on timezone settings #22850

Merged
merged 19 commits into from
Aug 18, 2021
Merged

[FIX] Return transcript/dashboards based on timezone settings #22850

merged 19 commits into from
Aug 18, 2021

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Aug 3, 2021 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Added new setting to manage timezones
  • Applied new setting to omnichannel dashboards (realtime, analytics) [NOTE: Other dashboards aren't using this setting actually)
  • Change getAnalyticsBetweenDate query to filter out system messages instead of substracting them

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman marked this pull request as draft August 3, 2021 21:50
@KevLehman KevLehman marked this pull request as ready for review August 9, 2021 18:59
sampaiodiego
sampaiodiego reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you changed a lot of console.log, may I ask you to use Logger instead? 🤗

@KevLehman
Copy link
Contributor Author

since you changed a lot of console.log, may I ask you to use Logger instead? 🤗

Done! 🚀

@renatobecker renatobecker added this to the 3.17.1 milestone Aug 13, 2021
@renatobecker renatobecker removed the request for review from murtaza98 August 13, 2021 14:41
@renatobecker renatobecker removed this from the 3.17.1 milestone Aug 13, 2021
@murtaza98 murtaza98 self-requested a review August 16, 2021 08:23
renatobecker
renatobecker approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@renatobecker renatobecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tiagoevanp tiagoevanp merged commit 1e66554 into develop Aug 18, 2021
@tiagoevanp tiagoevanp deleted the fix/timezone-dashboard-transcript branch August 18, 2021 13:58
@sampaiodiego sampaiodiego mentioned this pull request Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murtaza98 murtaza98 murtaza98 left review comments

@sampaiodiego sampaiodiego sampaiodiego left review comments

@renatobecker renatobecker renatobecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KevLehman @sampaiodiego @murtaza98 @renatobecker @tiagoevanp