Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW][APPS] Allow Rocket.Chat Apps to register custom action buttons #23679

Merged
merged 13 commits into from
Dec 20, 2021

Conversation

d-gubert
Copy link
Member

Proposed changes (including videos or screenshots)

Add an action button manager that allows apps to register custom action buttons that trigger interaction callbacks in them

Issue(s)

Steps to test or reproduce

Further comments

* Show buttons in contexts

* Change tabbar filter

* Improve room type filter

* Remove testing code and refactor IRoom auxiliary functions

* Add startup loadButtons

* Trigger new UI button interactions (#23798)

* Show buttons in contexts

* Change tabbar filter

* Handle action button interactions in endpoint

* Trigger new interaction type on UI buttons
@d-gubert d-gubert changed the title [NEW] Allow Rocket.Chat Apps to register custom action buttons [NEW][APPS] Allow Rocket.Chat Apps to register custom action buttons Dec 14, 2021
@d-gubert d-gubert added this to the 4.3.0 milestone Dec 17, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@d-gubert d-gubert marked this pull request as ready for review December 20, 2021 22:35
@d-gubert d-gubert requested a review from thassiov December 20, 2021 22:39
@d-gubert d-gubert merged commit abf453f into develop Dec 20, 2021
@d-gubert d-gubert deleted the feat/add-ui-buttons branch December 20, 2021 22:41
@felipetomm
Copy link

Hi @d-gubert
I think this new feature is awesome! But for make this more awesome, if you guys can share an gif/video in that cases of visual features, is really important for us (customers/community) 🙂

@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
@d-gubert
Copy link
Member Author

d-gubert commented Jan 5, 2022

Hey @felipetomm ! I think it would be nice, but what about some docs? https://developer.rocket.chat/apps-engine/fundamentals-of-apps/uikit/action-buttons 😉 😛

@felipetomm
Copy link

Nice! Docs have all we need :)
We will use it more from now on.

Thank you for your attention @d-gubert !

@murtaza98
Copy link
Contributor

Hi Team, Indeed a very useful feature 😍 I just tested this feature & it is working perfectly on browsers but I noticed the action buttons are still not visible on the mobile app. So, any plans on adding support for this on mobile devices too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants