Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show buttons in contexts #23724

Merged
merged 6 commits into from
Dec 14, 2021
Merged

Conversation

d-gubert
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan
Copy link
Contributor

What is the deal with eslint-import-plugin not handling that one?

@d-gubert
Copy link
Member Author

What is the deal with eslint-import-plugin not handling that one?

The updates to the Apps-Engine haven't been published yet, so they can't be resolved

@d-gubert d-gubert force-pushed the feat/add-ui-buttons-to-contexts branch from a4795e0 to 3bca091 Compare December 1, 2021 20:44
@d-gubert d-gubert changed the base branch from feat/add-ui-buttons to develop December 1, 2021 20:52
@d-gubert d-gubert changed the base branch from develop to feat/add-ui-buttons December 1, 2021 20:52
@d-gubert d-gubert marked this pull request as ready for review December 1, 2021 21:42
Copy link
Contributor

@AllanPazRibeiro AllanPazRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Show buttons in contexts

* Change tabbar filter

* Handle action button interactions in endpoint

* Trigger new interaction type on UI buttons
@d-gubert d-gubert merged commit 591e8bf into feat/add-ui-buttons Dec 14, 2021
@d-gubert d-gubert deleted the feat/add-ui-buttons-to-contexts branch December 14, 2021 13:01
d-gubert added a commit that referenced this pull request Dec 20, 2021
…23679)

* Add endpoint for fetching buttons

* Add a sync manager

* Add new websocket event

* Remove unnecessary call in action event

* Fix reference error

* Show buttons in contexts (#23724)

* Show buttons in contexts

* Change tabbar filter

* Improve room type filter

* Remove testing code and refactor IRoom auxiliary functions

* Add startup loadButtons

* Trigger new UI button interactions (#23798)

* Show buttons in contexts

* Change tabbar filter

* Handle action button interactions in endpoint

* Trigger new interaction type on UI buttons

* Handle timeout error

* Handle translation of the buttons names (#23975)

* Handle translation of the buttons names

* Update Apps-Engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants