-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show buttons in contexts #23724
Merged
d-gubert
merged 6 commits into
feat/add-ui-buttons
from
feat/add-ui-buttons-to-contexts
Dec 14, 2021
Merged
Show buttons in contexts #23724
d-gubert
merged 6 commits into
feat/add-ui-buttons
from
feat/add-ui-buttons-to-contexts
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-gubert
commented
Nov 17, 2021
d-gubert
commented
Nov 17, 2021
d-gubert
commented
Nov 17, 2021
What is the deal with |
The updates to the Apps-Engine haven't been published yet, so they can't be resolved |
d-gubert
force-pushed
the
feat/add-ui-buttons-to-contexts
branch
from
December 1, 2021 20:44
a4795e0
to
3bca091
Compare
KevLehman
reviewed
Dec 1, 2021
AllanPazRibeiro
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Show buttons in contexts * Change tabbar filter * Handle action button interactions in endpoint * Trigger new interaction type on UI buttons
d-gubert
added a commit
that referenced
this pull request
Dec 20, 2021
…23679) * Add endpoint for fetching buttons * Add a sync manager * Add new websocket event * Remove unnecessary call in action event * Fix reference error * Show buttons in contexts (#23724) * Show buttons in contexts * Change tabbar filter * Improve room type filter * Remove testing code and refactor IRoom auxiliary functions * Add startup loadButtons * Trigger new UI button interactions (#23798) * Show buttons in contexts * Change tabbar filter * Handle action button interactions in endpoint * Trigger new interaction type on UI buttons * Handle timeout error * Handle translation of the buttons names (#23975) * Handle translation of the buttons names * Update Apps-Engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments