Regression: Prevent connect to asterisk when VoIP is disabled

server/services/voip/connector/asterisk/CommandHandler.ts

@@ -150,5 +150,8 @@ export class CommandHandler {
 
 	stop(): void {
 		this.continuousMonitor.cleanMonitor();
+		for (const connection of this.connections.values()) {
+			connection.closeConnection();
+		}
 	}
 }

server/services/voip/service.ts

@@ -18,6 +18,7 @@ import { IQueueMembershipDetails, IRegistrationInfo, isIExtensionDetails } from
 import { IQueueDetails, IQueueSummary } from '../../../definition/ACDQueues';
 import { getServerConfigDataFromSettings } from './lib/Helper';
 import { IManagementServerConnectionStatus } from '../../../definition/IVoipServerConnectivityStatus';
+import { settings } from '../../../app/settings/server';
 
 export class VoipService extends ServiceClassInternal implements IVoipService {
 	protected name = 'voip';
@@ -31,11 +32,25 @@ export class VoipService extends ServiceClassInternal implements IVoipService {
 
 		this.logger = new Logger('VoIPService');
 		this.commandHandler = new CommandHandler(db);
-		try {
-			Promise.await(this.commandHandler.initConnection(CommandType.AMI));
-		} catch (error) {
-			this.logger.error({ msg: `Error while initialising the connector. error = ${error}` });
-		}
+		this.init();
+	}
+
+	private async init(): Promise<void> {
+		settings.watch('VoIP_Enabled', (value) => {
+			try {
+				if (value) {
+					this.logger.info('Starting VoIP service');
+					Promise.await(this.commandHandler.initConnection(CommandType.AMI));
+					this.logger.info('VoIP service started');
+				} else {
+					this.logger.info('Stopping VoIP service');
+					Promise.await(this.commandHandler.stop());
+					this.logger.info('VoIP service stopped');
+				}
+			} catch (error) {
+				this.logger.error({ msg: `Error while ${value ? 'initializing' : 'destroying'} the connector.`, err: error });
+			}
+		});
 	}
 
 	getServerConfigData(type: ServerType): IVoipCallServerConfig | IVoipManagementServerConfig {

tests/end-to-end/api/02-channels.js

@@ -281,6 +281,7 @@ describe('[Channels]', function () {
 	});
 
 	describe('[/channels.files]', () => {
+		before(() => updateSetting('VoIP_Enabled', true));
 		const createVoipRoom = async () => {
 			const testUser = await createUser({ roles: ['user', 'livechat-agent'] });
 			const visitor = await createVisitor();