Chore: Migrate LivechatVisitors model to raw #25756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging 7cd747c into 0b1073e - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging d42f0ec into 83851a0 - view on LGTM.com new alerts:
|
ggazzo
reviewed
Jun 11, 2022
…l-livechat-visitor
ggazzo
previously approved these changes
Jun 17, 2022
thassiov
previously approved these changes
Jun 17, 2022
…l-livechat-visitor
sampaiodiego
requested changes
Jun 23, 2022
| @@ -32,7 +32,7 @@ addMigration({ | |||
| }); | |||
|
|
|||
| if (updates.length) { | |||
| Promise.await(VisitorsRaw.col.bulkWrite(updates)); | |||
| Promise.await(LivechatVisitors.col.bulkWrite(updates)); | |||
There was a problem hiding this comment.
migrations can be async
Suggested change
| Promise.await(LivechatVisitors.col.bulkWrite(updates)); | |
| await LivechatVisitors.col.bulkWrite(updates); |
There was a problem hiding this comment.
C'mon, this mig is from like 4 months ago 
(But here's again to not to have it inside the loop)
…ketChat/Rocket.Chat into chore/migrate-model-livechat-visitor
sampaiodiego
previously approved these changes
Jun 23, 2022
|
This pull request introduces 7 alerts when merging b362bea into b77c075 - view on LGTM.com new alerts:
|
…l-livechat-visitor
sampaiodiego
approved these changes
Jun 24, 2022
sampaiodiego
changed the title
gabriellsh
added a commit
that referenced
this pull request
Jun 27, 2022
…turbo * 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits) Chore: Major refactors in pageobjects (#26015) [BREAK] Remove show message in main thread preference (#26002) Regression: Webhook Integration Creation + string error toast msg (#26008) Chore: convert e2e to ts (#25958) Regression: Room Endpoint Call Issues (#25928) Chore: Fixes e2e playwright intermittences (#25984) Chore: Fuselage update (#26004) Chore: Small fix on callProvider (#25963) [FIX] Initial members value on Create Channel Modal (#26000) Chore: Migrate from meteor model to raw (#25756) Chore: VoIP Context (#25994) Chore: Fuselage update (#25983) [FIX] sidebar colors (#25987) Regression: Non-reactive routes (#25990) [BREAK] use urlParams on omnichannel/agent/extension/ (#25982) [FIX] toolbox menu behind thread component (#25925) [FIX] Sort by scope or creation date not working on canned responses list (#25475) Chore: Colors (#25969) Revert "[BREAK] use urlParams on omnichannel/agent/extension/" (#25980) Regression: Prevent Form Submit on Reset Click ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments