Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] toolbox menu behind thread component #25925

Merged
merged 7 commits into from
Jun 23, 2022
Merged

[FIX] toolbox menu behind thread component #25925

merged 7 commits into from
Jun 23, 2022

Conversation

filipemarins
Copy link
Contributor

@filipemarins filipemarins commented Jun 20, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Add a container component to usePosition hook to prevent the menu be rendering outside the container.

Before:
Screen Shot 2022-06-20 at 08 19 08

After:
Screen Shot 2022-06-22 at 10 56 19

@filipemarins filipemarins requested a review from a team as a code owner June 20, 2022 11:27
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This crashes the view for extend threads when the screen is smaller.

@filipemarins filipemarins changed the title [FIX] z-index of chat wrapper [FIX] toolbox menu behind thread component Jun 22, 2022
ggazzo
ggazzo previously requested changes Jun 22, 2022
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is supposed to be a generic component, do not enter application details/context here
instead do something like
<ToolboxDropdown reference={ref} {...rest} container={PUT THE ELEMENT HERE}>

@filipemarins
Copy link
Contributor Author

this is supposed to be a generic component, do not enter application details/context here instead do something like <ToolboxDropdown reference={ref} {...rest} container={PUT THE ELEMENT HERE}>

Done 👍

@hugocostadev hugocostadev self-requested a review June 22, 2022 18:39
@filipemarins filipemarins dismissed stale reviews from gabriellsh and ggazzo June 22, 2022 18:42

changes done

@github-actions github-actions bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 23, 2022
@kodiakhq kodiakhq bot merged commit 25a04f9 into develop Jun 23, 2022
@kodiakhq kodiakhq bot deleted the zindex branch June 23, 2022 14:41
gabriellsh added a commit that referenced this pull request Jun 27, 2022
…turbo

* 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits)
  Chore: Major refactors in pageobjects (#26015)
  [BREAK] Remove show message in main thread preference (#26002)
  Regression: Webhook Integration Creation + string error toast msg (#26008)
  Chore: convert e2e to ts (#25958)
  Regression: Room Endpoint Call Issues (#25928)
  Chore: Fixes e2e playwright intermittences (#25984)
  Chore: Fuselage update (#26004)
  Chore: Small fix on callProvider (#25963)
  [FIX] Initial members value on Create Channel Modal (#26000)
  Chore: Migrate from meteor model to raw (#25756)
  Chore: VoIP Context (#25994)
  Chore: Fuselage update (#25983)
  [FIX] sidebar colors (#25987)
  Regression: Non-reactive routes (#25990)
  [BREAK] use urlParams on omnichannel/agent/extension/ (#25982)
  [FIX] toolbox menu behind thread component (#25925)
  [FIX] Sort by scope or creation date not working on canned responses list (#25475)
  Chore: Colors (#25969)
  Revert "[BREAK] use urlParams on omnichannel/agent/extension/" (#25980)
  Regression: Prevent Form Submit on Reset Click
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants