Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Migrate modules related to room template to TypeScript #25881

Merged
merged 50 commits into from
Aug 22, 2022

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan force-pushed the refactor/room-template branch from cbe947f to 9340338 Compare August 12, 2022 21:06
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #25881 (af011b8) into develop (6e3306b) will decrease coverage by 1.20%.
The diff coverage is 40.04%.

❗ Current head af011b8 differs from pull request most recent head 05eab63. Consider uploading reports for the commit 05eab63 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #25881      +/-   ##
===========================================
- Coverage    38.71%   37.51%   -1.21%     
===========================================
  Files          751      765      +14     
  Lines        18670    18613      -57     
  Branches      1453     1926     +473     
===========================================
- Hits          7228     6982     -246     
- Misses       11225    11342     +117     
- Partials       217      289      +72     
Flag Coverage Δ
e2e 37.51% <40.04%> (-1.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan changed the title Chore: refactor/room-template Chore: Migrate modules related to room template to TypeScript Aug 20, 2022
@tassoevan tassoevan marked this pull request as ready for review August 20, 2022 17:44
@tassoevan tassoevan requested review from a team as code owners August 20, 2022 17:44
ggazzo
ggazzo previously approved these changes Aug 22, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2022
@kodiakhq kodiakhq bot merged commit 8a2899f into develop Aug 22, 2022
@kodiakhq kodiakhq bot deleted the refactor/room-template branch August 22, 2022 18:48
gabriellsh added a commit that referenced this pull request Aug 24, 2022
…ove/otr-message

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  [FIX] Slack User CSV importer not working (#26629)
  Chore: Importer rest types, meteor methods to TS and API unit tests (#26284)
  [NEW] Adding oauth crud on the rocket.chat side (#26220)
  [NEW] allow ephemeral messages to receive a specific id (#26118)
  [FIX] MDM content alignment (#26665)
  Chore: Permissions check per endpoint/method (#26419)
  Regression: CI (#26658)
  [FIX] Not allowed error in discussion room with a private parent channel (#26394)
  Chore: Fix grammatical typo when only one message is pruned (#21902)
  [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575)
  i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645)
  Chore: Add license env var to ee tests (#26650)
  Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653)
  Regression: Custom status loading forever in Usercard (#26656)
  [FIX] Current Chat Custom Field Filter (#26200)
  Chore: Migrate modules related to `room` template to TypeScript (#25881)
  Chore: Create teams management tests (#26578)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants