Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] allow ephemeral messages to receive a specific id #26118

Merged
merged 11 commits into from
Aug 24, 2022

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Jul 4, 2022

Proposed changes (including videos or screenshots)

Allow apps to pass a specific ID for ephemeral messages as a way to edit them.

Issue(s)

Steps to test or reproduce

Further comments

@tapiarafael tapiarafael requested a review from d-gubert July 11, 2022 18:18
@tapiarafael tapiarafael marked this pull request as ready for review August 12, 2022 12:57
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #26118 (a84b83e) into develop (dd138b4) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26118      +/-   ##
===========================================
- Coverage    38.49%   38.33%   -0.16%     
===========================================
  Files          794      794              
  Lines        19002    19002              
  Branches      1937     1937              
===========================================
- Hits          7314     7284      -30     
- Misses       11398    11427      +29     
- Partials       290      291       +1     
Flag Coverage Δ
e2e 38.33% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 23, 2022
@kodiakhq kodiakhq bot merged commit 95d24cf into develop Aug 24, 2022
@kodiakhq kodiakhq bot deleted the feat/update-ephemeral-messages branch August 24, 2022 02:25
gabriellsh added a commit that referenced this pull request Aug 24, 2022
…ove/otr-message

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Add alsoSendThreadToChannel to user settings api (#26663)
  [IMPROVE] Spotlight search user results (#26599)
  [FIX] Slack User CSV importer not working (#26629)
  Chore: Importer rest types, meteor methods to TS and API unit tests (#26284)
  [NEW] Adding oauth crud on the rocket.chat side (#26220)
  [NEW] allow ephemeral messages to receive a specific id (#26118)
  [FIX] MDM content alignment (#26665)
  Chore: Permissions check per endpoint/method (#26419)
  Regression: CI (#26658)
  [FIX] Not allowed error in discussion room with a private parent channel (#26394)
  Chore: Fix grammatical typo when only one message is pruned (#21902)
  [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575)
  i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645)
  Chore: Add license env var to ee tests (#26650)
  Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653)
  Regression: Custom status loading forever in Usercard (#26656)
  [FIX] Current Chat Custom Field Filter (#26200)
  Chore: Migrate modules related to `room` template to TypeScript (#25881)
  Chore: Create teams management tests (#26578)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: apps stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants