Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAK] Upgrade to version 5.0 can be done only from version 4.x #26100

Merged
merged 2 commits into from
Jul 2, 2022

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jul 1, 2022

Proposed changes (including videos or screenshots)

I've changed migration 233 (the first one before version 4.0 to show an error in case it gets executed, because that means the server never ran 4.x.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego added this to the 5.0.0 milestone Jul 1, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 1, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 1, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jul 1, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@sampaiodiego sampaiodiego force-pushed the remove-not-supported-migrations branch from 9c8913f to 783d87d Compare July 1, 2022 21:50
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jul 1, 2022
@sampaiodiego sampaiodiego requested review from debdutdeb, KevLehman and a team July 1, 2022 22:00
Copy link
Member

@debdutdeb debdutdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

234 through 240 can be removed as well. but doesn't matter in terms of behavior

@kodiakhq kodiakhq bot merged commit 12c1cf6 into develop Jul 2, 2022
@kodiakhq kodiakhq bot deleted the remove-not-supported-migrations branch July 2, 2022 02:50
gabriellsh added a commit that referenced this pull request Jul 4, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  Chore: move fork of cas module to the monorepo (#26107)
  Chore: Add Agenda fork to the monorepo (#25681)
  Chore: Bump deps (#25624)
  [NEW][ENTERPRISE] Device Management (#25791)
  Chore: `refactor/tsc-perf` (#26040)
  [BREAK] Upgrade to version 5.0 can be done only from version 4.x (#26100)
  [BREAK] Remove support to old MongoDB versions (#26098)
  [NEW] Matrix Federation UX improvements (#25847)
  Regression: en.i18n.json spaces
  [NEW][ENTERPRISE] Introducing dial pad component into sidebar, calls table, contextual bar (#26081)
  Chore: Settings UI issue (#26053)
  Chore: Adding default message parser template (#26064)
  Regression: [VideoConference] If the caller loses connection, direct calls are never canceled (#26099)
  Chore: Handle errors on index creation (#26094)
  Chore: fix watermark condition (#26095)
  [FIX] Validate room access (#24534)
  [BREAK] VideoConference (#25570)
  [FIX] Undefined headers on API Client (#26083)
  Regression: Add Error boundary to katex render component (#26067)
  Chore: Allow endpoints to optionally require authentication (#26084)
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants