Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Remove method calls - Stage 1 #26149

Merged
merged 30 commits into from
Aug 12, 2022
Merged

Chore: Remove method calls - Stage 1 #26149

merged 30 commits into from
Aug 12, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 6, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested review from a team as code owners July 6, 2022 13:42
@ggazzo ggazzo changed the title Chore: Remove method calls for room menu component Chore: Remove method calls - Stage 1 Jul 11, 2022
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 25, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jul 26, 2022

This pull request introduces 2 alerts when merging 89d1733 into 45ee02d - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 8, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 8, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022 •
edited
Loading

Codecov Report

Merging #26149 (5df00d0) into develop (662ffb8) will decrease coverage by 0.20%.
The diff coverage is 33.33%.

❗ Current head 5df00d0 differs from pull request most recent head ceb9a7b. Consider uploading reports for the commit ceb9a7b to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26149      +/-   ##
===========================================
- Coverage    38.73%   38.52%   -0.21%     
===========================================
  Files          759      758       -1     
  Lines        18829    18816      -13     
  Branches      1459     1459              
===========================================
- Hits          7293     7249      -44     
- Misses       11319    11344      +25     
- Partials       217      223       +6
Flag Coverage Δ
e2e 38.52% <33.33%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 9, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 9, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 9, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 10, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 10, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 12, 2022
@ggazzo ggazzo merged commit 5b8b53e into develop Aug 12, 2022
@ggazzo ggazzo deleted the chore/remove-method-call branch August 12, 2022 20:50
csuadev pushed a commit that referenced this pull request Aug 26, 2022
@ggazzo @yash-rajpal
@juliajforesti @tassoevan
Chore: Remove method calls - Stage 1 (#26149)
e1a8b9d 
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>
Co-authored-by: Filipe Marins <filipe.marins@rocket.chat>
Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
methods removal stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggazzo @tassoevan @yash-rajpal @juliajforesti