Chore: Remove method calls - Stage 1

apps/meteor/app/api/server/v1/assets.ts

@@ -10,23 +10,25 @@ API.v1.addRoute(
 	{ authRequired: true },
 	{
 		async post() {
-			const [asset, { refreshAllClients }, assetName] = await getUploadFormData({
-				request: this.request,
-			});
+			const [asset, { refreshAllClients, assetName: customName }, fileName] = await getUploadFormData(
+				{
+					request: this.request,
+				},
+				{ field: 'asset' },
+			);
 
+			const assetName = customName || fileName;
 			const assetsKeys = Object.keys(RocketChatAssets.assets);
 
 			const isValidAsset = assetsKeys.includes(assetName);
 			if (!isValidAsset) {
 				throw new Meteor.Error('error-invalid-asset', 'Invalid asset');
 			}
 
-			Meteor.runAsUser(this.userId, () => {
-				Meteor.call('setAsset', asset.fileBuffer, asset.mimetype, assetName);
-				if (refreshAllClients) {
-					Meteor.call('refreshClients');
-				}
-			});
+			Meteor.call('setAsset', asset.fileBuffer, asset.mimetype, assetName);
+			if (refreshAllClients) {
+				Meteor.call('refreshClients');
+			}
 
 			return API.v1.success();
 		},

apps/meteor/app/e2e/client/tabbar.ts

@@ -1,6 +1,6 @@
 import { useMemo, useCallback } from 'react';
 import { useMutableCallback } from '@rocket.chat/fuselage-hooks';
-import { useSetting, usePermission, useMethod } from '@rocket.chat/ui-contexts';
+import { useSetting, usePermission, useEndpoint } from '@rocket.chat/ui-contexts';
 
 import { addAction } from '../../../client/views/room/lib/Toolbox';
 import { useReactiveValue } from '../../../client/hooks/useReactiveValue';
@@ -13,10 +13,10 @@ addAction('e2e', ({ room }) => {
 	const canEditRoom = usePermission('edit-room', room._id);
 	const hasPermission = (room.t === 'd' || (canEditRoom && canToggleE2e)) && e2eReady;
 
-	const toggleE2E = useMethod('saveRoomSettings');
+	const toggleE2E = useEndpoint('POST', '/v1/rooms.saveRoomSettings');
 
 	const action = useMutableCallback(() => {
-		toggleE2E(room._id, 'encrypted', !room.encrypted);
+		toggleE2E({ rid: room._id, encrypted: !room.encrypted });
 	});
 
 	const enabledOnRoom = !!room.encrypted;

apps/meteor/app/ui-utils/client/lib/AccountBox.ts

@@ -1,10 +1,11 @@
 import type { IUIActionButton, IUActionButtonWhen } from '@rocket.chat/apps-engine/definition/ui/IUIActionButtonDescriptor';
+import type { UserStatus } from '@rocket.chat/core-typings';
 import { ReactiveVar } from 'meteor/reactive-var';
 import { Tracker } from 'meteor/tracker';
-import { Meteor } from 'meteor/meteor';
 
 import { SideNav } from './SideNav';
 import { applyDropdownActionButtonFilters } from '../../../ui-message/client/actionButtons/lib/applyButtonFilters';
+import { APIClient } from '../../../utils/client';
 
 export interface IAppAccountBoxItem extends IUIActionButton {
 	name: string;
@@ -31,8 +32,8 @@ export class AccountBoxBase {
 
 	private status = 0;
 
-	public setStatus(status: number, statusText: string): any {
-		return Meteor.call('setUserStatus', status, statusText);
+	public setStatus(status: UserStatus, statusText: string): any {
+		return APIClient.post('/v1/users.setStatus', { status, message: statusText });
 	}
 
 	public open(): void {

apps/meteor/client/sidebar/RoomMenu.tsx

@@ -12,6 +12,7 @@ import {
 	useTranslation,
 	TranslationKey,
 	Fields,
+	useEndpoint,
 } from '@rocket.chat/ui-contexts';
 import React, { memo, ReactElement, useMemo } from 'react';
 
@@ -39,6 +40,24 @@ type RoomMenuProps = {
 	name?: string;
 };
 
+const closeEndpoints = {
+	p: '/v1/groups.close',
+	c: '/v1/channels.close',
+	d: '/v1/im.close',
+
+	v: '/v1/channels.close',
+	l: '/v1/groups.close',
+} as const;
+
+const leaveEndpoints = {
+	p: '/v1/groups.leave',
+	c: '/v1/channels.leave',
+	d: '/v1/im.leave',
+
+	v: '/v1/channels.leave',
+	l: '/v1/groups.leave',
+} as const;
+
 const RoomMenu = ({ rid, unread, threadUnread, alert, roomOpen, type, cl, name = '' }: RoomMenuProps): ReactElement => {
 	const t = useTranslation();
 	const dispatchToastMessage = useToastMessageDispatch();
@@ -54,11 +73,12 @@ const RoomMenu = ({ rid, unread, threadUnread, alert, roomOpen, type, cl, name =
 
 	const dontAskHideRoom = useDontAskAgain('hideRoom');
 
-	const hideRoom = useMethod('hideRoom');
-	const readMessages = useMethod('readMessages');
+	const hideRoom = useEndpoint('POST', closeEndpoints[type]);
+	const readMessages = useEndpoint('POST', '/v1/subscriptions.read');
+	const toggleFavorite = useEndpoint('POST', '/v1/rooms.favorite');
+	const leaveRoom = useEndpoint('POST', leaveEndpoints[type]);
+
 	const unreadMessages = useMethod('unreadMessages');
-	const toggleFavorite = useMethod('toggleFavorite');
-	const leaveRoom = useMethod('leaveRoom');
 
 	const isUnread = alert || unread || threadUnread;
 
@@ -78,7 +98,7 @@ const RoomMenu = ({ rid, unread, threadUnread, alert, roomOpen, type, cl, name =
 	const handleLeave = useMutableCallback(() => {
 		const leave = async (): Promise<void> => {
 			try {
-				await leaveRoom(rid);
+				await leaveRoom({ roomId: rid });
 				if (roomOpen) {
 					router.push({});
 				}
@@ -106,7 +126,7 @@ const RoomMenu = ({ rid, unread, threadUnread, alert, roomOpen, type, cl, name =
 	const handleHide = useMutableCallback(async () => {
 		const hide = async (): Promise<void> => {
 			try {
-				await hideRoom(rid);
+				await hideRoom({ roomId: rid });
 			} catch (error) {
 				dispatchToastMessage({ type: 'error', message: String(error) });
 			}
@@ -140,7 +160,7 @@ const RoomMenu = ({ rid, unread, threadUnread, alert, roomOpen, type, cl, name =
 	const handleToggleRead = useMutableCallback(async () => {
 		try {
 			if (isUnread) {
-				await readMessages(rid);
+				await readMessages({ rid });
 				return;
 			}
 			await unreadMessages(null, rid);
@@ -157,7 +177,7 @@ const RoomMenu = ({ rid, unread, threadUnread, alert, roomOpen, type, cl, name =
 
 	const handleToggleFavorite = useMutableCallback(async () => {
 		try {
-			await toggleFavorite(rid, !isFavorite);
+			await toggleFavorite({ roomId: rid, favorite: !isFavorite });
 		} catch (error) {
 			dispatchToastMessage({ type: 'error', message: String(error) });
 		}

apps/meteor/client/sidebar/header/EditStatusModal.tsx

@@ -1,7 +1,7 @@
 import type { IUser } from '@rocket.chat/core-typings';
 import { Field, TextInput, FieldGroup, Modal, Button } from '@rocket.chat/fuselage';
 import { useMutableCallback } from '@rocket.chat/fuselage-hooks';
-import { useToastMessageDispatch, useSetting, useMethod, useTranslation } from '@rocket.chat/ui-contexts';
+import { useToastMessageDispatch, useSetting, useTranslation, useEndpoint } from '@rocket.chat/ui-contexts';
 import React, { ReactElement, useState, ChangeEvent, useCallback } from 'react';
 
 import UserStatusMenu from '../../components/UserStatusMenu';
@@ -15,14 +15,15 @@ type EditStatusModalProps = {
 
 const EditStatusModal = ({ onClose, userStatus, userStatusText }: EditStatusModalProps): ReactElement => {
 	const allowUserStatusMessageChange = useSetting('Accounts_AllowUserStatusMessageChange');
-	const setUserStatus = useMethod('setUserStatus');
 	const dispatchToastMessage = useToastMessageDispatch();
 
 	const t = useTranslation();
 	const [statusText, setStatusText] = useState(userStatusText);
 	const [statusType, setStatusType] = useState(userStatus);
 	const [statusTextError, setStatusTextError] = useState<string | undefined>();
 
+	const setUserStatus = useEndpoint('POST', '/v1/users.setStatus');
+
 	const handleStatusText = useMutableCallback((e: ChangeEvent<HTMLInputElement>): void => {
 		setStatusText(e.currentTarget.value);
 
@@ -37,14 +38,14 @@ const EditStatusModal = ({ onClose, userStatus, userStatusText }: EditStatusModa
 
 	const handleSaveStatus = useCallback(async () => {
 		try {
-			await setUserStatus(statusType, statusText);
+			await setUserStatus({ message: statusText, status: statusType });
 			dispatchToastMessage({ type: 'success', message: t('StatusMessage_Changed_Successfully') });
 		} catch (error) {
 			dispatchToastMessage({ type: 'error', message: String(error) });
 		}
 
 		onClose();
-	}, [dispatchToastMessage, statusType, statusText, setUserStatus, onClose, t]);
+	}, [dispatchToastMessage, setUserStatus, statusText, statusType, onClose, t]);
 
 	return (
 		<Modal>

apps/meteor/client/sidebar/header/UserDropdown.tsx

@@ -42,7 +42,7 @@ const isDefaultStatus = (id: string): boolean => (Object.values(UserStatusEnum)
 const isDefaultStatusName = (_name: string, id: string): _name is UserStatusEnum => isDefaultStatus(id);
 
 const setStatus = (status: typeof userStatus.list['']): void => {
-	AccountBox.setStatus(status.statusType as unknown as number, !isDefaultStatus(status.id) ? status.name : '');
+	AccountBox.setStatus(status.statusType, !isDefaultStatus(status.id) ? status.name : '');
 	callbacks.run('userStatusManuallySet', status);
 };