[FIX] Unable to send voice recording to Whatsapp #26276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
approved these changes
Jul 15, 2022
KevLehman
requested changes
Jul 15, 2022
KevLehman
previously approved these changes
Jul 19, 2022
KevLehman
approved these changes
Jul 25, 2022
KevLehman
pushed a commit
that referenced
this pull request
Jul 27, 2022
murtaza98
added a commit
that referenced
this pull request
Jul 29, 2022
Closed
murtaza98
added a commit
that referenced
this pull request
Aug 1, 2022
murtaza98
added a commit
that referenced
this pull request
Aug 2, 2022
Closed
murtaza98
added a commit
that referenced
this pull request
Aug 2, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Apparently, WhatsApp doesn't accept an mp3 file without a valid magic number in its headers and RC doesn't add those headers to the mp3 file that it generates :( . This PR fixes that issue and makes it possible for agents to send a voice note to WhatsApp users
Steps to test or reproduce
Further comments
PR: https://app.clickup.com/t/2rq7jm6