Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Unable to send voice recording to Whatsapp #26276

Merged
merged 6 commits into from
Jul 27, 2022
Merged

[FIX] Unable to send voice recording to Whatsapp #26276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3aed5a9
[FIX] Unable to send voice recording to Whatsapp
murtaza98 Jul 15, 2022
d588d7e
Merge branch 'develop' into omni/whatsapp-audio-issue
murtaza98 Jul 15, 2022
062f9ca
Merge branch 'develop' into omni/whatsapp-audio-issue
murtaza98 Jul 20, 2022
c3d7b0a
Merge branch 'develop' into omni/whatsapp-audio-issue
murtaza98 Jul 25, 2022
827ce6c
Fix incorrect name being set for recorded audio file
murtaza98 Jul 25, 2022
750d3c7
fix prettier issue
murtaza98 Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/meteor/app/ui-message/client/messageBox/messageBoxAudioMessage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@ Template.messageBoxAudioMessage.events({
const { rid, tmid } = this;
const blob = await cancelRecording(instance, rid, tmid);

await fileUpload([{ file: blob, type: 'video', name: `${t('Audio record')}.mp3` }], { input: blob }, { rid, tmid });
const fileName = `${t('Audio record')}.mp3`;
const file = new File([blob], fileName, { type: 'audio/mpeg' });

await fileUpload([{ file, type: 'audio/mpeg', name: fileName }], { input: blob }, { rid, tmid });
},
});
5 changes: 4 additions & 1 deletion apps/meteor/app/ui/client/lib/recorderjs/audioEncoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ class AudioEncoder extends Emitter {
handleWorkerMessage = (event) => {
switch (event.data.command) {
case 'end': {
const blob = new Blob(event.data.buffer, { type: 'audio/mpeg' });
// prepend mp3 magic number to the buffer
const magicNoPrefix = new Int8Array([73, 68, 51, 3, 0, 0, 0, 0, 0, 0]);
murtaza98 marked this conversation as resolved.
Show resolved Hide resolved
const bufferWithMagicNo = [magicNoPrefix, ...event.data.buffer];
const blob = new Blob(bufferWithMagicNo, { type: 'audio/mpeg' });
this.emit('encoded', blob);
this.worker.terminate();
break;
Expand Down