Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Migrate omni-chat forwarding to use API instead of meteor method #26377

Merged
merged 13 commits into from
Aug 16, 2022
Merged

Chore: Migrate omni-chat forwarding to use API instead of meteor method #26377

merged 13 commits into from
Aug 16, 2022

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Jul 27, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Use livechat/room.forward endpoint to forward omnichannel chats instead of using meteor method "livechat:transfer"

Issue(s)

Steps to test or reproduce

Further comments

Pending tasks:

  • Migrate UI to use this endpoint instead of meteor method
  • Tests

@codecov
Copy link

codecov bot commented Jul 29, 2022 •
edited
Loading

Codecov Report

Merging #26377 (79f34b7) into develop (4f946a0) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26377      +/-   ##
===========================================
+ Coverage    38.67%   38.70%   +0.02%     
===========================================
  Files          758      758              
  Lines        18816    18816              
  Branches      1459     1459              
===========================================
+ Hits          7278     7283       +5     
+ Misses       11320    11314       -6     
- Partials       218      219       +1
Flag Coverage Δ
e2e 38.70% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 changed the title Chore: Add tests for livechat/room.forward endpoint Chore: Migrate omni-chat forwarding to use API instead of meteor method Aug 7, 2022
@murtaza98 murtaza98 marked this pull request as ready for review August 8, 2022 06:07
@murtaza98 murtaza98 requested review from a team as code owners August 8, 2022 06:07
@murtaza98 murtaza98 requested a review from KevLehman August 8, 2022 06:07
KevLehman
KevLehman previously approved these changes Aug 9, 2022
View reviewed changes
ggazzo
ggazzo previously approved these changes Aug 9, 2022
View reviewed changes
@murtaza98 murtaza98 dismissed stale reviews from ggazzo and KevLehman via 529b6f6 August 10, 2022 06:04
@murtaza98 murtaza98 requested review from ggazzo and KevLehman August 10, 2022 06:06
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 16, 2022
@murtaza98 murtaza98 requested a review from a team as a code owner August 16, 2022 11:45
@alvaropmello alvaropmello added this to the 5.1.0 milestone Aug 16, 2022
@kodiakhq kodiakhq bot merged commit 521e747 into develop Aug 16, 2022
@kodiakhq kodiakhq bot deleted the tests-livechatForward branch August 16, 2022 12:42
csuadev pushed a commit that referenced this pull request Aug 26, 2022
@murtaza98
Chore: Migrate omni-chat forwarding to use API instead of meteor meth…
14a73ea 
…od (#26377)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevLehman KevLehman KevLehman approved these changes

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@murtaza98 @ggazzo @KevLehman @alvaropmello