Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display Avatar Preference not hiding avatars on messages #27072

Merged

Conversation

nishant23122000
Copy link
Contributor

@nishant23122000 nishant23122000 commented Oct 14, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Closes #26741

Steps to test or reproduce

  • Go to the user account
  • Go to preferences
  • In Message Section use the toggle button to disable or enable the Display avatar

You will able to toggle it, but if it's enabled, messages are rendering along with the user avatar.

Further comments

@nishant23122000 nishant23122000 requested a review from a team as a code owner October 14, 2022 18:37
@nishant23122000
Copy link
Contributor Author

This same issue happens with a The hide username also. before that, I'm Waiting for the reviewer to check whether it's the right approach to do or not.

@nishant23122000 nishant23122000 changed the title [BUG] Unable To Disable Display Showing Avatar [BUG] Unable To Disable Display Avatar In User Preferences Oct 14, 2022
@dudanogueira
Copy link
Contributor

Hi! There is at least 3 issues reagarding the real name issue areound:
#23051
#21480
#21129

Indeed it needs more discussion.
Thanks for this PR!! I'll put it with our team.

@debdutdeb debdutdeb changed the title [BUG] Unable To Disable Display Avatar In User Preferences [FIX] Unable To Disable Display Avatar In User Preferences Oct 16, 2022
@dougfabris dougfabris changed the title [FIX] Unable To Disable Display Avatar In User Preferences [FIX] Display Avatar Preference not working Mar 1, 2023
@dougfabris dougfabris changed the title [FIX] Display Avatar Preference not working [FIX] Display Avatar Preference not hiding avatars on messages Mar 1, 2023
@dougfabris dougfabris added this to the 6.1.0 milestone Mar 1, 2023
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the comment and apply to all cases

@nishant23122000 nishant23122000 requested review from ggazzo and removed request for debdutdeb and ggazzo March 4, 2023 07:16
@dougfabris dougfabris requested review from ggazzo and removed request for debdutdeb March 6, 2023 12:34
@dougfabris dougfabris changed the title [FIX] Display Avatar Preference not hiding avatars on messages fix: Display Avatar Preference not hiding avatars on messages Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #27072 (0296ab3) into develop (8db691d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27072      +/-   ##
===========================================
+ Coverage    45.14%   45.17%   +0.02%     
===========================================
  Files          755      755              
  Lines        14607    14607              
  Branches      2085     2085              
===========================================
+ Hits          6595     6598       +3     
+ Misses        7717     7715       -2     
+ Partials       295      294       -1     
Flag Coverage Δ
e2e 45.12% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA stat: ready to merge PR tested and approved waiting for merge labels Mar 15, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 15, 2023
@kodiakhq kodiakhq bot merged commit 13569f5 into RocketChat:develop Mar 15, 2023
@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Avatars switch: unable to disable showing avatars in messages
7 participants