-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 6.2.0 #28950
Merged
Merged
Release 6.2.0 #28950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com>
Co-authored-by: Felipe <84182706+felipe-rod123@users.noreply.github.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
KevLehman
approved these changes
May 15, 2023
ggazzo
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2.0
2023-05-15 · 9 🎉 · 2 🚀 · 80 🐛 · 290 🔍 · 56 👩💻👨💻
Engine versions
14.21.3
6.14.17
4.4, 5.0, 6.0
1.39.0
🎉 New features
add GA4 support (#28830 by @avelino)
auto link custom domain (#28501)
Changes:
Auto Link Custom Domain new setting under Message group path:
/admin/settings/Message
New translation keys for English
Adding types to message-parser
Options
New hook
useAutoLinkDomains
to get the setting and return an array of domainsCurrent:
Desirable:
Output when the setting has the value:
local,intranet
New setting:
Custom roles and Public&Private apps stats (#27781)
Make the marketplace search bar placeholder dynamic (#28394)
Jira task: AECO-24
Now the placeholder of the marketplace search bar will change based on which page of marketplace the user is browsing.
Demo gif:
Message Forwarding (#26662)
Implement the ability to forward messages to another channel, thread, or discussion. This is a high demand capability that is currently missing in Rocket.Chat. It can significantly improve the user's experience and her/his productivity. The scope of this project will be limited to the web application (not for mobile apps).
Special thanks to @nishant23122000 that helped us with this during GSOC 2022
moderation dashboard (#28962)
Release PR for the
feat/moderation-dashboard
implementing the Beta version of the Moderation Console. For more details & some previews on Moderation Console, read here -> feat: Moderation Console #27961 (comment)New timeout setting for Omnichannel Webhooks (#28219 by @cauefcr)
Costumers were complaining about duplicated data from the Omnichannel webhooks, so I added a new setting that controls the timeouts for the webhooks, in the omnichannel->webhooks panel, the default values are 5s for http timeout, and 4x that for the retry timeout, or 20s.
Registered Loom oEmbed (#28339 by @Nabhag8848)
VideoConference Guest mode and Conference Router (#28186)
Jira Issue: [VC-79]
🚀 Improvements
Adding input type=password to AWS secrets fields (#28159)
Some fields that store secrets for AWS were exposing sensitive data because they didn't have the input type as
password
.The change includes adding the password type and also changing the autocomplete value from
<PasswordInput />
component to add the valuenew-password
to avoid the browser autocompleting with the existing password. (This does not prevent the browser to show the hint to add the password)Galician onboarding translation (#27908 by @Thiagof99)
I've translated the entire onboarding page and forms to galician language. Here's an example of how the forms look now:
🐛 Bug fixes
rocket.cat help command not showing the shortcut for one #28762 - fix missing command in /help (#28777 by @adarshlilha)
When using
/help
command in any room the rocket.cat bot lists all keyboard shortcuts for the operations that can be done in rocket chat but for one command(marking all messages as read) shortcut is not being rendereredbefore fix screenshot:
post fix screenshot:
ComposerPopupPreview
trespassing the composer limit (#28896)before
after
emoji
property in messages not being respected (#28416)There's a property on the message object called
emoji
which allow the sender (bot, app, API, integration, etc) to replace the user avatar with an emoji. Since we rewrote the messages to React, this was not being supported.UI_Use_Real_Name
not being respected in quotes and RoomForeword (#28613)Updated pertinent places and made it so user
name
is always sent with message (empty if non-existant).Before:
After:
Add function to get installation source (#28806)
There have been reports of problems regarding the missing information of
installationSource
in apps. The only scenario where this information could be missing is if migrations failed to run properly when upgrading to 6.0. We haven't been able to identify the root cause yet, so we decided to provide a workaround in the meanwhileApp crashing when switching to Hindi (hi-In) language (#28285 by @bhardwajdisha)
app status inconsistencies when running multiple instances in a cluster (#29180)
App status inconsistencies between multiple instances in a cluster boil down to the fact that the Apps-Engine is currently responsible for orchestrating when these events are triggered and is overly verbose in doing so.
Upon analysis, the framework itself should not have the concept of "other instances" - this is a deployment detail of the host system, and as such should be controlled by the host. The correct solution for this problem is to review this notification system, potentially removing it from the framework and leaving the responsibility solely for Rocket.Chat.
However, this is hindering the current app management experience for workspaces, so this PR cuts the control of some notifications that come from the framework (the more problematic ones) and moves the control over to RC in a short and practical way.
This is done by turning the methods of the most problematic events in the
AppActivationBridge
into no-ops, and instead triggering theAppServerNotifier
directly in the api endpoints that are applicable.It is not the most correct solution to the problem, but due to time constraints and urgency this will be applied first so we can move with the correct solution in a future point.
application crashing when clicking on files button (#28878 by @jayesh-jain252)
The application crashed when a user clicked on the files option when there were multiple files in the room.
After:
Apps.engine resource consumption (#28514)
Added some validations to avoid doing unnecessary updates and also avoid loop that causes high server usage
Avoid
useEffect
loop (#28699)A bug in
useUserBanners
hooks will generate a infinite loop whenever a new user banner (e.g. new version announcement) is available. This PR fixes it.Avoid throw error on
settings.watch
at startup (#28649)Bring unseen app requests badge back and minor refactors (#28348)
Brought back the unseen app requests badge that disappeared due to a development oversight and fixed some typos and style issues.
change default text color in homepage custom content block (#28685)
color="info"
), but should actually be blackBefore:
After:
Changing the app's error verification (#28450)
check if custom field is required to apply rule (#28428 by @filipemarins)
Fix save button is not enabled until non-required custom fields are not filled under room information.
composer slashcommands duplication (#29086)
Confirm password flow fixed and refactored (#28453 by @XshubhamX)
convert OVERWRITE_SETTING type MULTISELECT to array (#29208)
Delete accounts modal asks for a username instead of the password (#28883)
Jira task: WM-2
Fixed a misuse of the password.bcrypt data. This info shouldn't be exposed to the front-end. Not only that, but it also wasn't available to the front-end causing a bug in which the user would be prompted for their username when deleting their account even if they had a password. Also changed the text of the account deletion confirmation modal so that it better uses the spacing of the Generic Modal.
Demo gif:
Display Avatar Preference not hiding avatars on messages (#27072)
Emoji don't work after text in contiunous (#28216 by @Bankar-Swapnil)
Engagement dashboard crash on Users tab (#28131)
Error logging in with TOTP on "reset password" workflow (#28938)
Error message is displayed in case no file is found in custom sound section. (#28302 by @bhardwajdisha)
Export as PDF button is disabled when chat is closed by the visitor (#28305 by @filipemarins)
Fix the
export as PDF
button is disabled when chat is closed by the visitor;Fixed business hours route redirect (#28344)
This PR fixes the user being redirected to a blank page after editing the business hours.
Fixed no role assign to manual registered users despite of Default Roles for Users settings (#28293 by @bhardwajdisha)
Fixing the user status change by app (#28965)
Fuselage's icon font reloads too often (#28673)
Gallery opening other image after closing (#27957)
How to reproduce:
1 - Upload MANY images to a channel (they have to be images and the bigger and more images the easier to reproduce)
2 - Click on one of the images
3 - Try to close the glalery as QUICK as possible
If done correctly, another image will open after closing the gallery. You could also try opening different images or throttling the network thru the devtools in order to help reproduce it.
I also took some time to make part of the code more readable.
Generic Table Search (#28401)
When the user changes the page and tries to search for a room that is not currently visible on the page it’s not returning any results. This is also reproducible in the Users table
Current Behavior:
It returns the list filtering by the name
Previous Behavior:
Not found - It was not finding the room because it’s filtering only in the current page
Google Cloud Storage not working (#29244)
Hide System Messages for room requires refresh (#28584)
Adittionaly fixed a bug in the Edit Channel contextual bar where the
hide system messages
option wasn't updating on removing the last item.Horizontal scroll in main room if text is too long (#28434)
Removed inline styles from elements and substituted
p
tag fordiv
For a quick explanation, the
p
tag adds the multiple line breaks by default when copying text. We should revise in the parser how we deal with paragraphs and text blocks.Invalid JSON in Custom Translations setting crashes the UI (#28600)
Check if JSON code settings (with
type: code
andcode: application/json
) are valid before saving, or throw an error otherwise;Dismiss custom settings when the custom translations JSON provided is invalid (instead of throwing an error and crashing the UI);
Fix the Custom Translations setting desciption so that the example is shown as a code snippet.
Leader Bar presence status alignment (#28793)
Livechat MessageList not auto scrolling on new message (#28547)
Livechat notifications not working correctly (#28741)
Livechat Triggers not working (#29073)
marketplace doc link wrong redirect (#28466)
Fixed a problem in which the FlowRouter was breaking external links passed to the SidebarItem component.
Example of wrong behavior (after clicking on the marketplace Documentation option):
Demo gif (after fix):
marketplace requested glitch (#28445)
message-parser links (#28735)
When sending URLs with certain characters, the hyperlink gets cut off.
For example:
https://www.nimblepcm.com/(W(601))/Main?ScreenId=GI000027
URL gets cut off after "(601"
That doesn't happen with all URLs.
MessageBoxReplies attachments preview (#28579)
The
MessageBoxReplies
component was not displaying the attachments previews in the correct way, it was using theDefaultAttachment
instead.To accomplish the expected behavior I had to do the following changes:
Edit the
MessageBoxReplies
to add acollapsed
prop to the attachments to always start as collapsedAdd a new prop to the
MessageCollapsible
component to control the preview attachments inMessageBoxReplies
to always start as collapsedEdit the Attachment components to read the
collapsed
value and send it thoughtEdited the
ShareMessageModal
to display the correct attachment and its previewsEdited the
useCollapse
hook prop as optional because was not making sense to put it as mandatory since it was getting the value from the user preferences as default and for theMessageCollapsible
work in a dynamic wayCurrent Behavior:
Expected Behavior
Messages jumping after reaction (#28770)
Migration error when removing 'snipetted' index (#29215)
migration to fix apps in invalid state (#29210)
Due to a conflict between 5.4.x and 6.0, if the upgrade of a workspace is done using a Rolling upgrade strategy, it is likely that apps will be left in an invalid (potentially unusable) state.
We can solve apps left in this state by adding another migration.
missing margins in message composer icons (#28430)
.rcx-button-group__item
prop in message box components for horizontal marginBefore:
After:
New marketplace uxdqa (#28390)
Fix all ux problems found by design on the new marketplace.
Jira tasks (All the details of issues solved in this PR can be found on these tasks):
AECO-18: Enabled apps counter has wrong spacing - M: fix: App Limitations UI changes #28391
AECO-21: Disabled state of request button showing the text "request" instead of "requested"
AECO-22: Upsell modal has wrong spacing between its title and its image - M: fix: App Limitations UI changes #28391
AECO-23: Request tab visible inside of private apps page - M: chore: Hide requests tab when inside of private apps page #28392
AECO-25: Wrong title on enabled apps counter when inside of the private apps page - M: fix: App Limitations UI changes #28391
AECO-48: UXDQA app listing - M: chore: Change marketplace AppRow typography #28500
AECO-49: UXDQA app detail - M: chore: Change marketplace app details page header spacing #28499
No feedback given in case of wrong password input in modal confirm password (#28276 by @bhardwajdisha)
Normal and multiline messages adding extra spaces upon copying/pasting (#28187 by @Educg550)
null email for SSO User on Profile Page (#22438 by @Shailesh351)
Offline register option (#28467)
Prevent blank space on live chat form validations (#28243 by @filipemarins)
quote line break (#28798)
Big messages are being rendered correctly on the chat but when quoted, the UI stops wrapping them correctly.
The change was made on
fuselage
, this PR only updates its version.fuselage PR: fix(fuselage): MessageBody word break fuselage#1018
Before:
Now:
Quotes chain off by one error in quote chain limit settings (#28281 by @jayesh-jain252)
Fixed off by one error in Quote Chain Limit. Now if a user sets Message_QuoteChainLimit (default is 2) the number of quotes chained matches the setting.
Changes are made in apps/meteor/app/oembed/server/jumpToMessage.ts file
With Message_QuoteChainLimit=2
Before:
After:
redirect not authorized and room not found errors (#29150)
Redirect Meteor.Error to RoomNotFoundError to show the correct page
Before:
After:
remove link appearing in quotes preview (#28443 by @jayesh-jain252)
When a user chained quotes for more than 2 times, there was a link appearing in the quotes preview
Before:
After:
Resolve Reset Password feature not sending email for emails containing capital letters (#28778 by @Pranshu1902)
Responsiveness of New Integration (#27645 by @adijr9487)
Improved the responsiveness by adding maxWidth property.
Restriction setting not being applied to the old UFS route (#28363)
Revert breaking change to groups.list API: 404 vs. empty list (#27587 by @nmagedman)
API calls that request a list of groups which meet some criteria should return an empty list when appropriate, rather than 404. This was the pre-v5.0.0 behavior.
Routing fixed for private apps in marketplace section (#28418 by @ayush3160)
This pull request fixes the irregular behavior of routing in the Private Apps section of the Marketplace. The issue was caused by the passing of three parameters (id of app, marketplaceVersion, and tab) to the route when opening an app's details. In the case of private apps, the marketplaceVersion was returning undefined, which caused the version to take on the value of the tab when redirecting. To resolve this issue, I have updated the code to pass the version of the app when the marketplaceVersion returns undefined. This fix ensures that the routes behave as expected in the Private Apps section of the Marketplace.
Rocket.Chat.-.14.March.2023.mp4
Show all users on rooms members list (#28413)
Single omni closed room can't be deleted when the user doesn't have the permission to 'remove all closed omni rooms' (#28877)
Small UI bugs (#28893)
It fixes an insidious bug affecting the focus of the message composer whenever the user start typing. It also reverts some refactored code that affected desktop app users (e.g. cut/copy/paste not working).
SMTP warnings on user form (#28832)
Check for SMTP config on server side and then show warning on client side
sound notification for queued chats with manual routing (#28411 by @filipemarins)
Don't play notification sound for disabled agents and also respect the
poolMaxIncoming
setting to play or not the notification;Refactor queue manager to ts.
team channel reload error message (#28667)
Thread list not scrolling to bottom when sending a message. (#28346)
Thread message preview (#28454)
The thread preview message was not displaying emojis and when the parent message was a quoted message it was not displaying the correct message.
To fix the issues I did:
Emoji Issue: I used the
<GazzodownText />
component to call<PreviewMarkup />
conditionally when passed the proppreview
. The<GazzodownText />
component it's necessary because it has theMarkupInteractionContext.Provider
that has the context necessary to display the emoji and other elementsEmpty parent message: Since the parent message it's a quote, the initial string from a quote message it's a link that references the original message followed by
\n
break line. I added a validation to check if it's a quoteAttachment message, if it is I remove the first markdown token responsible by the linkBefore:
After:
Thread message preview to ignore hide_FlexTab preference (#28470)
Added
role='link'
so that hide_flextab preference is ignored on this DOM node.ui crash if no app requests found (#29107)
Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
Complementary it replaces
useEndpointData
in favor ofuseQuery
Unnecessary useQuery refetch (#28451)
Sometimes when the user focuses on the window that is running the Rocket.Chat some queries are triggered again without a reason, to prevent this to happen I added a option to
useQuery
hook,refetchOnWindowFocus: false
Queries impacted:
useThreadMainMessageQuery.ts - called when has to get the thread main message, for e.g in thread preview reply
useHasLicenseModule.ts - called when the client starts to show/hide certain areas that are restricted by licenses, this don't change very often
use raw image url (#28861 by @avelino)
videoconf stream (#28455)
Whatsapp quotes not working due to livechat url change (#29153)
When clicking on display option their checked status does not changes (#27881 by @AdityaSingh-02)
word break in rcx-message-body (#28904)
Changes made on the fuselage repo: fix(fuselage): word break in rcx-message-body fuselage#1028
The CSS added into
rcx-message-body
word-break: break-all;
was breaking a word in the middle in the messages.To change this behavior and break the entire word I changed to
word-break: break-word;
Previous
NOW
Wrong error message when trying to create new team with existing team name (#28270 by @Bankar-Swapnil)
🔍 Minor changes
A lot =)
👩💻👨💻 Contributors 😍
👩💻👨💻 Core Team 🤓