Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] UserCard not opening inside Threads #27096

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner October 19, 2022 00:05
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #27096 (d390b22) into develop (b11fb06) will decrease coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27096      +/-   ##
===========================================
- Coverage    41.31%   40.46%   -0.85%     
===========================================
  Files          801      826      +25     
  Lines        17676    18116     +440     
  Branches      1996     2058      +62     
===========================================
+ Hits          7302     7330      +28     
- Misses       10084    10492     +408     
- Partials       290      294       +4     
Flag Coverage Δ
e2e 40.46% <ø> (-0.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 5.4.0 milestone Oct 31, 2022
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 1, 2022
@kodiakhq kodiakhq bot merged commit 824a008 into develop Nov 2, 2022
@kodiakhq kodiakhq bot deleted the fix/usercard-threads branch November 2, 2022 03:14
gabriellsh added a commit to sidmohanty11/Rocket.Chat that referenced this pull request Nov 3, 2022
…ranch2

* 'develop' of github.com:RocketChat/Rocket.Chat: (1555 commits)
  Chore: Show better error logs (RocketChat#27156)
  [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150)
  Chore: Convert client/views/directory/hooks to ts (RocketChat#26936)
  Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937)
  [FIX] UserCard not opening inside Threads (RocketChat#27096)
  [FIX] Gap between message content and message header when there's no text. (RocketChat#27165)
  Chore: docs grammar fix (RocketChat#26894)
  [FIX]  Removed mobile requirement for showing real name (RocketChat#26968)
  Chore: Cursor pointer to all the action buttons (RocketChat#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109)
  Chore: Enable PR Title Checker for forks (RocketChat#27144)
  Chore: Converting game center to typescript (RocketChat#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127)
  Chore: Add info log to remove all rooms method (RocketChat#27106)
  [IMPROVE] Quotes on E2EE Messages (RocketChat#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866)
  [FIX] Room Avatar being deleted after upload. (RocketChat#27060)
  Chore: Apps/Marketplace code organization (RocketChat#27061)
  ...
gabriellsh added a commit that referenced this pull request Nov 3, 2022
…llowArchived

* 'develop' of github.com:RocketChat/Rocket.Chat: (2426 commits)
  Chore: Show better error logs (#27156)
  [FIX] Message search breaking URL, usertags and emojis (#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (#27150)
  Chore: Convert client/views/directory/hooks to ts (#26936)
  Chore: Convert client/views/directory/RoomTags to ts (#26937)
  [FIX] UserCard not opening inside Threads (#27096)
  [FIX] Gap between message content and message header when there's no text. (#27165)
  Chore: docs grammar fix (#26894)
  [FIX]  Removed mobile requirement for showing real name (#26968)
  Chore: Cursor pointer to all the action buttons (#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (#27109)
  Chore: Enable PR Title Checker for forks (#27144)
  Chore: Converting game center to typescript (#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (#27127)
  Chore: Add info log to remove all rooms method (#27106)
  [IMPROVE] Quotes on E2EE Messages (#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (#26866)
  [FIX] Room Avatar being deleted after upload. (#27060)
  Chore: Apps/Marketplace code organization (#27061)
  ...
gabriellsh added a commit to Kartik18g/Rocket.Chat that referenced this pull request Nov 3, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (2462 commits)
  [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177)
  Chore: Show better error logs (RocketChat#27156)
  [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150)
  Chore: Convert client/views/directory/hooks to ts (RocketChat#26936)
  Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937)
  [FIX] UserCard not opening inside Threads (RocketChat#27096)
  [FIX] Gap between message content and message header when there's no text. (RocketChat#27165)
  Chore: docs grammar fix (RocketChat#26894)
  [FIX]  Removed mobile requirement for showing real name (RocketChat#26968)
  Chore: Cursor pointer to all the action buttons (RocketChat#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109)
  Chore: Enable PR Title Checker for forks (RocketChat#27144)
  Chore: Converting game center to typescript (RocketChat#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127)
  Chore: Add info log to remove all rooms method (RocketChat#27106)
  [IMPROVE] Quotes on E2EE Messages (RocketChat#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866)
  [FIX] Room Avatar being deleted after upload. (RocketChat#27060)
  ...
gabriellsh added a commit to im-adithya/Rocket.Chat that referenced this pull request Nov 3, 2022
…password-change

* 'develop' of github.com:RocketChat/Rocket.Chat: (2885 commits)
  [FIX] Uploading Custom Sound files not working, but showing success (RocketChat#27177)
  Chore: Show better error logs (RocketChat#27156)
  [FIX] Message search breaking URL, usertags and emojis (RocketChat#20878)
  [NEW] REST API endpoint `/v1/oauth-apps.create` (RocketChat#27054)
  i18n: Language update from LingoHub 🤖 on 2022-10-31Z (RocketChat#27150)
  Chore: Convert client/views/directory/hooks to ts (RocketChat#26936)
  Chore: Convert client/views/directory/RoomTags to ts (RocketChat#26937)
  [FIX] UserCard not opening inside Threads (RocketChat#27096)
  [FIX] Gap between message content and message header when there's no text. (RocketChat#27165)
  Chore: docs grammar fix (RocketChat#26894)
  [FIX]  Removed mobile requirement for showing real name (RocketChat#26968)
  Chore: Cursor pointer to all the action buttons (RocketChat#24440)
  Chore: Bump actions/upload-artifact from 2 to 3 (RocketChat#27109)
  Chore: Enable PR Title Checker for forks (RocketChat#27144)
  Chore: Converting game center to typescript (RocketChat#26915)
  i18n: Language update from LingoHub 🤖 on 2022-10-24Z (RocketChat#27127)
  Chore: Add info log to remove all rooms method (RocketChat#27106)
  [IMPROVE] Quotes on E2EE Messages (RocketChat#26303)
  [NEW] REST API endpoint `/v1/rooms.delete` (RocketChat#26866)
  [FIX] Room Avatar being deleted after upload. (RocketChat#27060)
  ...
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants